comunica / comunica-feature-link-traversal

📬 Comunica packages for link traversal-based query execution
Other
8 stars 11 forks source link

Login for Solid Demo of link traversal is broken #100

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

Issue type:


Description:

On https://query.linkeddatafragments.org/ one can successfully login and query over Solid. However, when trying to do the same on https://comunica.github.io/comunica-feature-link-traversal-web-clients/builds/solid-default/ you are immediately met with the error {"error":"invalid_grant","error_description":"Invalid redirect_uri"} when trying to log in.

~It appears that this is because https://comunica.github.io/comunica-feature-link-traversal-web-clients/builds/solid-default/ incorrectly encodes the redirect_uri parameter to be https%3A%2F%2Fcomunica.github.io%2Fcomunica-feature-link-traversal-web-clients%2Fbuilds%2Fsolid-default%2F wheras https://query.linkeddatafragments.org/ does not encode the parameter using a redirect_uri of https://query.linkeddatafragments.org/.~

The problem is that both supply the clientId https://query.linkeddatafragments.org/solid-client-id.json; which states that the redirect_uri should be https://query.linkeddatafragments.org/ and hence does not align with the expected redirect uri for the link traversal build.


Environment:

Crash log:

github-actions[bot] commented 1 year ago

Thanks for reporting!

jeswr commented 1 year ago

I'm really struggling to find where the problem is since https://comunica.github.io/comunica-feature-link-traversal-web-clients/builds/solid-default/ seems to be building using the latest version of the jquery source in https://github.com/comunica/comunica-feature-link-traversal/blob/75f8e33aefde4d8bb19cd9daa54605cb76866879/web-clients/build-web-clients.sh#L23