Closed constraintAutomaton closed 1 month ago
Before I review in detail, could you @RubenEschauzier first have a look at this as well? This feels somewhat related to your prioritization work.
I don't know why the CI doesn't pass on my end it does. Even the solidbench the one which is the one failing.
I don't know why the CI doesn't pass on my end it does. Even the solidbench the one which is the one failing.
The failure looks unrelated to your PR.
Another thought I have that would simplify this PR: Instead of writing to file, we could just write to the logger (e.g. at TRACE level). An external script could then be used to filter the log messages related to the link queue. This would make this PR work in the browser as well.
Looks pretty good, it is a much more refined version of what I used for the link queue analysis paper. I'm unsure if it has much to do with prioritization, as (as far as I can tell) it is mainly for analyzing query execution in hindsight.
Looks pretty good, it is a much more refined version of what I used for the link queue analysis paper. I'm unsure if it has much to do with prioritization, as (as far as I can tell) it is mainly for analyzing query execution in hindsight.
I think it is the part about the labeling of the links with the reachability criteria. At least for my work I plan to use those label to prioritize some links.
Another thought I have that would simplify this PR: Instead of writing to file, we could just write to the logger (e.g. at TRACE level). An external script could then be used to filter the log messages related to the link queue. This would make this PR work in the browser as well.
Yes, I think it is much better! I will be also able to provide the information in a streaming manner (instead of dumping it all at every step, but I think I will provide the option to do so). I will make another repo to parse this information has a file because it make it easy for my own investigation and debugging.
Objective
The objective of this actor is to collect information about the link queue and to serialize it into a file. The information collected are the following:
It is also possible to add custom link queue properties via the
IOptionalLinkQueueParameters
, but for their parsing the code has to be modified.A label for each current reachability criteria also has been added. They can optionally label each link coming out of the extract-link actors. This feature doesn't only have the purpose to document the link queue occupancy but can be use in future work for engine optimization such has link queue ordering.
The
@comunica/actor-rdf-resolve-hypermedia-links-queue-wrapper-info-occupance:query-identifier
property can also be used to identify the query.Example output
Config of the wrapper actor
Config of the engine
output
If an identifier was given for the query than the
query
field will be this identifier.Future works