search

comunica / comunica-feature-link-traversal

📬 Comunica packages for link traversal-based query execution
Other
8 stars 11 forks source link

Add ActorExtractLinksHeaders #130

Closed wdantuma closed 3 months ago

wdantuma commented 3 months ago

ActorExtractLinksHeaders

ActorExtractLinksHeaders is a ActorExtractLinks actor which adds links in link headers matching a regex pattern, usable for also following Auxillary resource links like "describedby" and "acl"

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

rubensworks commented 3 months ago

Thanks @wdantuma, this looks really useful! I'll have a look at it next week.

rubensworks commented 3 months ago

@wdantuma I just had a look, and everything looks great to me!

The reason why the CI is still failing is because the new actor will have to be added as a dependency to engines/query-sparql-link-traversal and engines/query-sparql-link-traversal-solid: https://github.com/comunica/comunica-feature-link-traversal/blob/master/engines/query-sparql-link-traversal/package.json#L51 Could you look into adding it at those 2 locations?

wdantuma commented 3 months ago

@rubensworks i have added the dependencies to the new actor, thanks for the review

rubensworks commented 3 months ago

Thanks @wdantuma! Released as 0.4.0.

RubenVerborgh commented 1 month ago

Posterior note that we should thread carefully, as this changes query semantics wrt completeness.