search

comunica / comunica-feature-link-traversal

📬 Comunica packages for link traversal-based query execution
Other
8 stars 11 forks source link

Added implicit predicate domain support for type index actor #90

Closed Sindhu-Vasireddy closed 1 year ago

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

Sindhu-Vasireddy commented 1 year ago

Hi @rubensworks, I've now addressed all pull request suggestions, Kindly check and let me know.

Sindhu-Vasireddy commented 1 year ago

@rubensworks I've now resolved the comments, could you kindly have a look and let me know at your convenience.

Sindhu-Vasireddy commented 1 year ago

@rubensworks I've now resolved the comments, could you kindly have a look and let me know at your convenience.

Sindhu-Vasireddy commented 1 year ago

Code is in perfect shape now. Really nice work @Sindhu-Vasireddy, this is a really nice contribution!

Once you've confirmed that things still work as intended with SolidBench, I'll merge this.

@rubensworks I have checked that this works with the current version of Solidbench. I have also addressed the changes on that PR as well.

rubensworks commented 1 year ago

Perfect, thanks for checking!

Could you just resolve the merge conflict? I'll merge it right away then.

rubensworks commented 1 year ago

Really nice work @Sindhu-Vasireddy! 🎉