search

comunica / comunica-feature-link-traversal

📬 Comunica packages for link traversal-based query execution
Other
8 stars 11 forks source link

Make `source`s optional on link traversal engines #92

Closed jeswr closed 1 year ago

jeswr commented 1 year ago

Issue type:

Description:

I'm finding myself writing things like

const res = await (new QueryEngine).queryBindings(/* query */,
    // We provide no sources because we are in a link traversal setting
    // @ts-ignore
    {
      '@comunica/actor-http-inrupt-solid-client-authn:session': session
    }
  );

a lot; it would be good to have the types reflect the fact that sources are optional in a link traversal context

github-actions[bot] commented 1 year ago

Thanks for the suggestion!

rubensworks commented 1 year ago

Yes, fully agree!

Should be easy to do now that we have https://github.com/comunica/comunica/commit/ca7e6cf64741ec5075673dbef0374c6d033d1b9a