search

comunica / jQuery-Widget.js

🖼 A jQuery widget to query heterogeneous interfaces using Comunica SPARQL
http://query.linkeddatafragments.org/
MIT License
18 stars 35 forks source link

Use YASQE as SPARQL query editor #13

Closed rubensworks closed 6 years ago

rubensworks commented 6 years ago

As suggested in #8, this enables the YASQE query editor for SPARQL queries.

This does increase the main UI asset size from 239 KB to 709 KB, which is above webpack recommended asset limit of 244 KB. This means that people on slow machines/internet connections might have to wait a bit before they can start querying.

@RubenVerborgh Do you think this ^ is a blocker ?

@joachimvh Can you try breaking it? :-)

joachimvh commented 6 years ago

Regarding the size, maybe we can release multiple versions somehow or would that be too much overhead to keep them consistent?

rubensworks commented 6 years ago

too much overhead to keep them consistent

Yes, overhead would be a bit too high in the current form of this widget.

joachimvh commented 6 years ago

Things I could find so far:

RubenVerborgh commented 6 years ago

Yes, overhead would be a bit too high in the current form of this widget.

Given that you've only needed to add code (not remove or change), an if (yasqe) should be sufficient.

RubenVerborgh commented 6 years ago

@RubenVerborgh Do you think this ^ is a blocker ?

Not at all, good stuff!

rubensworks commented 6 years ago

When going to the client the SPARQL field is empty whereas it used to contain a query (the first one in the list of queries).

Ah, that's because YASQE does some internal caching. I'll see what I can do.

  • Not sure whether something can be changed about this, but when I add a newline in a query the indentation starts at the wrong level.
  • The expand button in the top right overlaps with the scrollbar.

I think these are issues in YASQE itself.