comunica / jQuery-Widget.js

🖼 A jQuery widget to query heterogeneous interfaces using Comunica SPARQL
http://query.linkeddatafragments.org/
MIT License
18 stars 35 forks source link

incorrect ampersand escaping in SPARQL client execution log URLs #148

Closed balhoff closed 1 year ago

balhoff commented 1 year ago

Issue type:


Description:

I'm trying out the query interface on https://query.linkeddatafragments.org/ and have been looking at the execution log to understand how my local ldf-server is being queried. The requests in the execution log are hyperlinked, so that I can click on them to see the results in the ldf-server interface. However, ampersands separating query parameters are escaped, such that the query parameters aren't passed correctly to the ldf-server.

Here is one line copied from the execution log. The hyperlinked URL matches the text here.

Requesting http://localhost:3000/go-cam?predicate=http%3A%2F%2Fwww.w3.org%2F1999%2F02%2F22-rdf-syntax-ns%23type&object=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0008150&graph=urn%3Aldf%3AdefaultGraph {"headers":{"accept":"application/n-quads,application/trig;q=0.95,application/ld+json;q=0.9,application/n-triples;q=0.8,*/*;q=0.1","user-agent":"Comunica/actor-http-fetch (Browser-Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15)"},"method":"GET","actor":"urn:comunica:default:http/actors#fetch"}

Instead of http://localhost:3000/go-cam?predicate=http%3A%2F%2Fwww.w3.org%2F1999%2F02%2F22-rdf-syntax-ns%23type&object=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0008150&graph=urn%3Aldf%3AdefaultGraph the linked URL should be http://localhost:3000/go-cam?predicate=http%3A%2F%2Fwww.w3.org%2F1999%2F02%2F22-rdf-syntax-ns%23type&object=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FGO_0008150&graph=urn%3Aldf%3AdefaultGraph

With the incorrectly escaped URL, the object ends up being empty when following the link to the ldf-server. This made me worry that the SPARQL client was not working correctly, although I believe it actually is.

github-actions[bot] commented 1 year ago

Thanks for reporting!