comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

put ts in strict mode and fix #111

Closed jitsedesmet closed 3 years ago

jitsedesmet commented 3 years ago

This PR doesn't really fix any issues but it prevents them from occurring. I enabled "strict": true, "strictFunctionTypes": false, "strictPropertyInitialization": false in the typescript config and fixed the problems this caused.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1167179902


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/aggregators/Max.ts 2 3 66.67%
lib/aggregators/Min.ts 2 3 66.67%
<!-- Total: 19 21 90.48% -->
Totals Coverage Status
Change from base Build 1166618006: -0.1%
Covered Lines: 1505
Relevant Lines: 1629

💛 - Coveralls
jitsedesmet commented 3 years ago

Btw, would like to ask you not to merge this yet. Even when you think it's ready :)

jitsedesmet commented 3 years ago

Alright, we should be able to merge this now.