comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

Feature/buffer & open world typing #112

Closed jitsedesmet closed 3 years ago

jitsedesmet commented 3 years ago

This pull request aims to close #109 .

What this PR does:

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1166602057


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/functions/NamedFunctions.ts 27 28 96.43%
lib/transformers/TermTransformer.ts 47 50 94.0%
lib/evaluators/evaluatorHelpers/AsyncRecursiveEvaluator.ts 23 28 82.14%
lib/evaluators/evaluatorHelpers/SyncRecursiveEvaluator.ts 22 27 81.48%
lib/functions/Helpers.ts 64 72 88.89%
lib/functions/RegularFunctions.ts 99 112 88.39%
lib/transformers/AlgebraTransformer.ts 59 74 79.73%
<!-- Total: 627 677 92.61% -->
Totals Coverage Status
Change from base Build 1162151356: 0.3%
Covered Lines: 1503
Relevant Lines: 1625

💛 - Coveralls
jitsedesmet commented 3 years ago

Just wondering I we shouldn't use the general config/context in places where the openworld config thing is passed.

We could do this for sure. We can then also make SuperTypeCallback async. To handle this we would then also need to provide Static create method so the creation can be async. Some problems will arise handling normal construction but we'll see about that.