search

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

Add more tests #118

Closed jitsedesmet closed 1 year ago

jitsedesmet commented 3 years ago

This pull request doesn't provide any new features. It adds some new tests to increase coverage. And asks some questions on certain tests.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+2.7%) to 92.078% when pulling cb4c49fd847a99857cc2d6fa838396357998e320 on jitsedesmet:test/buff-up-test into 003af86ec98483e3f4e572637282c747174d0fb3 on comunica:master.

jitsedesmet commented 3 years ago

I don't understand the question @jitsedesmet is the unary plus operator not applied?

Indeed, the operator is not applied. Is there any reason for this that you ca remember?

wschella commented 3 years ago

I don't understand the question @jitsedesmet is the unary plus operator not applied?

Indeed, the operator is not applied. Is there any reason for this that you ca remember?

Not really.

Tpt commented 2 years ago

@jitsedesmet Hi! I am working to improve sparqlee code coverage. Would you be ok if I try to move forward your pull request?

jitsedesmet commented 2 years ago

Not at all. Go ahead. I would be happy if it can be of any use!

Tpt commented 2 years ago

Great! Thank you!