Closed jitsedesmet closed 3 years ago
Should we rebase the relevant commits onto the master for this PR and the other similar ones?
Yes, we should :) I plan on doing this before Monday but a lot is happening right now so it might get delayed. This PR and #120 should just get rebased and then they should be ready to merge. Like I said, we should first finish #120 and Ruben asked a question there that needs to be looked into.
Since this depends on #120, let's put this one on hold until the changes discussed in #120 are applied.
@rubensworks I will now just merge this with #120 and resolve the conflicts so we can merge this into master?
Sounds good!
Something weird happened during the merge, but it should be fine now.
(Will wait again for merging until @wschella gives his +1)
I'm very busy this week and coming ones, so I don't really have the bandwidth to cover this PR together with the related ones in depth. After a quick glance everything seems definitely okay.
Around December I will give a pass to the new system in it's entirety myself. But everything can definitely be merged.
@wschella No worries, a quick glance is fine :-)
Great work!
This PR builds on top of #120 . It increases the execution time to a point where we almost want to keep the new type system I think.
Execution times:
This means there is only a +-5% decrease when using the new type system.
It can be seen as a part of #119 and might provide an example of the kind of optimizations we need.