Closed Tpt closed 2 years ago
If I understand correctly, this check is in place for varargs expressions such as CONCAT
.
Do you think this check is invalid?
If I understand correctly, this check is in place for varargs expressions such as CONCAT. Do you think this check is invalid?
The check is valid but unused because CONCAT
is currently implemented a a "special" operator because regular function evaluation utilities do not support varargs at the moment.
To cover this alternative properly with a test I would need either to do a huge refactoring to add proper dependency injection or hack on the regular function map to add a fake function only for the test and remove it afterward. I prefered to completely drop this piece of code in the assumption that no code is better than dead code. But if you think differently, I am find with hacking a test for it.
Ah I see. Definitely makes sense in that case!
Not usable in practice because of implementation restrictions