Closed Tpt closed 2 years ago
About the "uplus" function, it is not emitted by the SPARQL parser (RubenVerborgh/SPARQL.js/issues/152). I see thre options to archive full code coverage:
@RubenVerborgh What do you think about it?
Perfect! No comments here :-)
About the "uplus" function, it is not emitted by the SPARQL parser (https://github.com/RubenVerborgh/SPARQL.js/issues/152). I see thre options to archive full code coverage:
If @RubenVerborgh agrees I would go for option 2: Emit it from SPARQL.js It might also require a small change in SPARQLAlgebra.js, but @joachimvh might know more about this.
It might also require a small change in SPARQLAlgebra.js, but @joachimvh might know more about this.
SPARQLAlgebra.js copies the expression functions directly from SPARQL.js so my guess is it would need no changes (except perhaps an update to the SPARQL.js dependency).
If @RubenVerborgh agrees I would go for option 2: Emit it from SPARQL.js
Yes please!
All the lines in the
functions
directory should be covered except for theuplus
function.This PR also fixes float/doubles parsing and serialization of NaN and infinities.
It also removes some dead code in the helpers.