search

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

100% code coverage #157

Closed Tpt closed 2 years ago

Tpt commented 2 years ago

Covers the remaining pieces of code and enforces 100% code coverage

Closes #38

coveralls commented 2 years ago

Coverage Status

Coverage increased (+1.9%) to 100.0% when pulling 82c3deb61ccde9c8818cad043576f8ccfa0559c6 on Tpt:minor-coverage into 4b836de99ca8be8f611d23578d949d1330e95f74 on comunica:master.

rubensworks commented 2 years ago

Excellent work @Tpt! 🎉 I guess this completes the bounty?

Do you think there are any other test-related issues that can be closed now? (not saying there should be)

Tpt commented 2 years ago

Excellent work @Tpt!

Thank you!

I guess this completes the bounty?

Yes, if you think so.

Do you think there are any other test-related issues that can be closed now? (not saying there should be)

I believe #35 is at least partially fulfilled (maybe some small parts are still missing like "Subtype substitution" that won't be highlighted by code coverage). About #37, all functions are now covered by either Sparqlee hand written tests or the port of the official test suite but I don't think all behaviors of all all functions are tested (there are shared utility functions so if each piece of the utility functions is covered by one test for one function is enough to get 100% test coverage). But testing all behaviors of all functions would be quite a lot of work (it means e.g. test the full EBV behavior for each logical function...).

rubensworks commented 2 years ago

Ok, let's keep #35 and #37 open then.