search

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

Remove old type system #162

Closed jitsedesmet closed 1 year ago

jitsedesmet commented 1 year ago

This PR aims to remove the old type system alltogether. I discovered an optimization that made the experimental type system at least as fast as the old one. Since the new one is stronger and easier to maintain, we will use that one as default. It was also a pain to make sure the code did the correct thing in both type systems.

It will be noted that one order test broke and I just switched them. IRC the only importance in that scenario was that the order had some concistency.

The PR deprecates the overloadCache and enableExtendedXsdTypes config options.

PS: I'm sorry my first PR in a while is this big hehe.

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling a8335da7b5dce8daf7dd13503903340a3479dcd2 on jitsedesmet:speedup/speedup-new-type-system into 4b29c97e9296db7561785f395a558ffed63b89a2 on comunica:master.

jitsedesmet commented 1 year ago

Both the tests and spec test vahe been run on the communica repo and they pass.

rubensworks commented 1 year ago

@jitsedesmet Before I release this, can you double-check on your end that all tests (+spec and integration) still pass in Comunica with this version?