search

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

DRAFT - Fix string functions #164

Closed jitsedesmet closed 1 year ago

jitsedesmet commented 1 year ago

Running the spec test of the Comunica repo showed something was wrong with the implementation of our new type system for the substr function. It turned out this was because substr is supposed to execute on a SPARQL_STRINGLY and not on an xsd_string. I altered this and checked the sparql specs whether more functions had this issue. This PR should fix this all string functions. (PS: the name used in the sparql spec for a SPARQL_STRINGLY is string literal)

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling f1e4e53e0a4a881d2d3eccfae6ce87ba7656811c on jitsedesmet:bugfix/fix-string-functions into 206df0eaf03c7c70068ad9383585f34a9494d257 on comunica:master.