Test both async and sync implementations

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator

https://www.npmjs.com/package/sparqlee

14 stars 7 forks source link

Test both async and sync implementations #36

Closed wschella closed 3 years ago

wschella commented 5 years ago

Currently the test script always uses the async implementation. This way however we have no clue whether the sync one works as well. And although it has the same logic largely, there are some differences, certainly for the special functions.

jitsedesmet commented 3 years ago

I will try to close this issue by creating generalEvaluation. This will evaluate both sync and async in case a syncConfig object is provided and Test only async in case an asyncConfig object is provided.

jitsedesmet commented 3 years ago

A first implementation broke 4 tests. These tests need to be studied closer so the underlying issue can be fixed.

test/spec/in02.spec.ts (1)
test/functions/op.bnode.test.ts (2) -> This was a problem with the test interfering with the way the implementation of generalEvaluation works
test/spec/notin01.spec.ts (1)

wschella commented 3 years ago

Great that you found them!

jitsedesmet commented 3 years ago

Report:

The in / notin test: a return was forgotten.
The bnode test: the test was statefull and interfered with the way generalEvaluation works.