search

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator
https://www.npmjs.com/package/sparqlee
14 stars 7 forks source link

Test all functions #37

Closed wschella closed 1 year ago

wschella commented 5 years ago

The spec tests are very insufficient for testing all logic (certainly in regards to types) of all functions. For every function we should add a test ourselves.

jitsedesmet commented 1 year ago

I think this issue can be closed? Haven't checked manually, but I don't see how we could have got 100% coverage if we don't test all functions.

wschella commented 1 year ago

It originally meant better testing (for all functions). The fact that you have full coverage doesn't necessarily means you test all cases between interacting functions. And the spec tests don't cover much. That said, this issue is a bit too vague (and could thus be closed), but we should be aware there is room for more tests, especially w.r.t. typing logic.

jitsedesmet commented 1 year ago

I agree. Better tests could be beneficial. However, since we can not test everything and I don't see any benefit in transferring this issue to Comunica, I will close it.