Closed wschella closed 2 years ago
@wschella or @rubensworks, do you have a reference on where to find these test?
Probably these ones: https://github.com/w3c/rdf-tests/tree/main/sparql11/data-sparql11/aggregates
Since these are also a lot of files, I will split the spec directory.
I've been trying for quite some time now. I have no idea on how to test this within sparqlee. Take for example the agg2 test. If I'm not mistaken we have a whole actor in comunica to handle these kind of combinations? How would we go about testing this here?
I don't think the intention was to copy the tests as-is. But instead, to select the elements of these tests that are applicable to sparqlee, i.e., those that interact directly with the aggregate evaluator.
So we would just exclude the agg2
test? because I don't think we can test this.
You'll know better than me, but can't we test the COUNT
part?
If I remember correctly, grouping is done purely on the Comunica side, so that can't be tested in Sparqlee indeed.
Yes, I guess we could. I'll write the tests. Doesn't really seem all that valuable to me but I guess it's nice to have.
I think that this issue can be closed because of #131? Like I said here before (https://github.com/comunica/sparqlee/issues/41#issuecomment-900339813) the test is already included in the Comunica repo.
Sure.
As we did for the spec tests for functions, we should copy the spec tests for aggregates from the test-repo.