Replaces create-hash with hash.js and spark-md5

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator

https://www.npmjs.com/package/sparqlee

14 stars 7 forks source link

Replaces create-hash with hash.js and spark-md5 #78

Closed jacoscaz closed 3 years ago

jacoscaz commented 3 years ago

This PR replaces create-hash with the combination of hash.js and spark-md5.

The idea came from https://github.com/comunica/comunica/pull/752 , in which @rubensworks and I discussed strategies to decrease the amount of unused crypto-related code ending up in browser-side bundles of comunica.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 418

6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 82.074%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/functions/RegularFunctions.ts	6	7	85.71%
<!--	Total:	6	7	85.71%	-->

Totals
Change from base Build 416:	0.01%
Covered Lines:	1098
Relevant Lines:	1299

💛 - Coveralls

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 419

6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 82.074%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/functions/RegularFunctions.ts	6	7	85.71%
<!--	Total:	6	7	85.71%	-->

Totals
Change from base Build 416:	0.01%
Covered Lines:	1098
Relevant Lines:	1299

💛 - Coveralls

rubensworks commented 3 years ago

Thanks! I'll make sure to include this change in the new Comunica release.