rubensworks
commented
3 years ago You'll have to remove this line to make the CI work: https://github.com/comunica/sparqlee/blob/master/.github/workflows/ci.yml#L25
Closed jitsedesmet closed 3 years ago
rubensworks
commented
3 years ago You'll have to remove this line to make the CI work: https://github.com/comunica/sparqlee/blob/master/.github/workflows/ci.yml#L25
coveralls
commented
3 years ago | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/evaluators/BaseAggregateEvaluator.ts | 3 | 4 | 75.0% | ||
| lib/expressions/Aggregate.ts | 0 | 1 | 0.0% | ||
| lib/functions/Core.ts | 15 | 16 | 93.75% | ||
| lib/functions/XPathFunctions.ts | 28 | 29 | 96.55% | ||
| lib/evaluators/AsyncEvaluator.ts | 5 | 7 | 71.43% | ||
| lib/evaluators/RecursiveExpressionEvaluator.ts | 14 | 16 | 87.5% | ||
| lib/evaluators/SyncEvaluator.ts | 3 | 5 | 60.0% | ||
| lib/expressions/Existence.ts | 1 | 3 | 33.33% | ||
| lib/functions/NamedFunctions.ts | 21 | 23 | 91.3% | ||
| lib/functions/RegularFunctions.ts | 61 | 66 | 92.42% | ||
| <!-- | Total: | 417 | 473 | 88.16% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/functions/Helpers.ts | 2 | 82.93% | ||
| <!-- | Total: | 2 | --> |
| Totals | |
|---|---|
| Change from base Build 1096748252: | -0.4% |
| Covered Lines: | 1261 |
| Relevant Lines: | 1398 |
jitsedesmet
commented
3 years ago It should be noted that I got the initial configuration for the eslint configuration here
This pull request aims to close issue #93. I also opened 2 new issues, #94 and #95, both issues provide insight into problems that became clear while migrating to eslint.