Clean/generalize test into one backbone

comunica / sparqlee

⚙️ SPARQL expression evaluator library - Moved to @comunica/expression-evaluator

https://www.npmjs.com/package/sparqlee

14 stars 7 forks source link

Clean/generalize test into one backbone #97

Closed jitsedesmet closed 3 years ago

jitsedesmet commented 3 years ago

This pull request aims to clean the test suit and provides a little more explanation on how tests work and how you can write new ones.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1104455148

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.745%

Totals
Change from base Build 1100387159:	0.0%
Covered Lines:	1261
Relevant Lines:	1398

💛 - Coveralls

jitsedesmet commented 3 years ago

I could just re-enable the test disabled in #40 so this PR should close that issue.

jitsedesmet commented 3 years ago

I guess a template would be pretty cool. Personally I like the current syntax because it provides a nice description on the function. A template is a bit harder for arity: 'vary' but that one is a bit of a weird one anyway :/ . Anyway, I personalty like the description syntax we have now a bit more.

wschella commented 3 years ago

I guess a template would be pretty cool. Personally I like the current syntax because it provides a nice description on the function. A template is a bit harder for arity: 'vary' but that one is a bit of a weird one anyway :/ . Anyway, I personalty like the description syntax we have now a bit more.

It's true, it showcases clearly which properties of the function are relevant for the logic behind it. Let's keep it without templates.