search

comwes / mkpdfs-mkdocs-plugin

Converts your mkdocs documentation in PDF, to be shared with users
https://comwes.github.io/mkpdfs-mkdocs-plugin
GNU General Public License v3.0
103 stars 36 forks source link

Feature/missingcss #20

Closed lavahot closed 3 years ago

lavahot commented 4 years ago

Fixes #12, fixes #17, and fixes #19.

trogper commented 4 years ago

Can you also remove it from .gitignore so git installs would work also?

lavahot commented 4 years ago

@trogper that kind of contradicts the principle of not adding built resources to scm. I thought about this a bit and the pythonic way would be building it on install, but that means I'd have to add npm as a dependency, which feels weird. I could bundle the modularscale-sass package directly into the package, and that would seem to be the most robust solution. But then we still need to install the dependencies to do the build.

So I guess what I'm saying is that I'm not sure that including report.css in source is the correct decision.

trogper commented 4 years ago

I know it is not the correct way, but I think it's better to include it or at least provide some way of not having to compile it.

On windows you need to install node-gyp which is 3GB including dependencies. But at least there's WSL