search

comwes / mkpdfs-mkdocs-plugin

Converts your mkdocs documentation in PDF, to be shared with users
https://comwes.github.io/mkpdfs-mkdocs-plugin
GNU General Public License v3.0
103 stars 36 forks source link

Incompatible with 1.1 #23

Closed ghost closed 3 years ago

ghost commented 4 years ago

With mkdocs 1.1 and material 5.1.7, can't render pdfs, I get

/python3.8/site-packages/mkpdfs_mkdocs/mkpdfs.py", line 20, in Mkpdfs ('design', config_options.Type(utils.string_types, default=None)),

AttributeError: module 'mkdocs.utils' has no attribute 'string_types'

I assume it is this same problem: https://github.com/zhaoterryy/mkdocs-pdf-export-plugin/commit/7c6c82c96490a84b4bd617e21977259f60dd5007

jwaschkau commented 4 years ago

Hi Moronic,

see #15

trogper commented 4 years ago

This should already be fixed in git, but is not yet released on pypi.
I suggest you to try the newest code from git and close the issue

markvincze commented 4 years ago

Hey @comwes,

Are you planning to do a new release in the near future so that this fix would be rolled out?

jollyparamjit commented 4 years ago

I am using mkdocs==1.1.2 & mkdocs-material 5.3.0 for my project.

mkdocs-material 5.3.0 has requirement mkdocs>=1.1, but you'll have mkdocs 1.0.4 which is incompatible.

Can you help, how do i keep mkdocs 1.1.2 & this pdf plugin.

jwaschkau commented 4 years ago

I am using mkdocs==1.1.2 & mkdocs-material 5.3.0 for my project.

mkdocs-material 5.3.0 has requirement mkdocs>=1.1, but you'll have mkdocs 1.0.4 which is incompatible.

Can you help, how do i keep mkdocs 1.1.2 & this pdf plugin.

Hi,

you can install from my repository until the PR`s are merged. It works with mkdocs >=1.1 and i tested it with mkdocs-material 5.3.2.

https://github.com/jwaschkau/mkpdfs-mkdocs-plugin.git#egg=mkpdfs-mkdocs-plugin

vasicvuk commented 4 years ago

When will this fix be released?

Deastrom commented 4 years ago

Can we please get this released. Not having good luck with a competing plugin and would like to see how this one works.

or please provide instructions on how to install this plugin outside of pip.

trogper commented 4 years ago

@deastrom

Can we please get this released. Not having good luck with a competing plugin and would like to see how this one works.

or please provide instructions on how to install this plugin outside of pip.

pip install git+https://github.com/jwaschkau/mkpdfs-mkdocs-plugin.git#egg=mkpdfs-mkdocs-plugin

fletort commented 4 years ago

@Deastrom

Can we please get this released. Not having good luck with a competing plugin and would like to see how this one works. or please provide instructions on how to install this plugin outside of pip.

pip install git+https://github.com/jwaschkau/mkpdfs-mkdocs-plugin.git#egg=mkpdfs-mkdocs-plugin

WIth this method you have now the bug #19 :-)

Deastrom commented 4 years ago

Yeah... I'm playing with Dita now

trogper commented 4 years ago

you can pull the css from official pypi package and put it into the git-installed one, that should help

comwes commented 3 years ago

Issue will be fixed in the upcoming relaase