search

comwes / mkpdfs-mkdocs-plugin

Converts your mkdocs documentation in PDF, to be shared with users
https://comwes.github.io/mkpdfs-mkdocs-plugin
GNU General Public License v3.0
103 stars 36 forks source link

Add a test in order to test issue such the one reported in here #41

Closed comwes closed 3 years ago

comwes commented 3 years ago

Now I remember what the issue was. It was caused, I think, by mkdocs itself. When you had heading on a page with diacritics, the element id (used for hash navigation) skipped diacritical letters (heading "Červená máňa" had id "erven-ma") which was very impractical. We resorted to using uslugify, which stripped only diacriticals, not whole letters. You can probably take my comments just as a "reminder" to test tolerance to unicode characters

Originally posted by @trogper in https://github.com/comwes/mkpdfs-mkdocs-plugin/issues/35#issuecomment-843328558

comwes commented 3 years ago

@trogper as you can see in the joined pdf, your exemple is working as expected. I think the problem might probably occur with python2 which we are planning to no longer support starting the upcoming release.

docu-test.pdf

KR, @comwes

trogper commented 3 years ago

actually the link in Second topic does not work. is it linked to the first topic or to červená máňa?

comwes commented 3 years ago

Indeed that link does not work because the page it is supposed to reference does not exist in the generated pdf which is normal.