search

comwes / mkpdfs-mkdocs-plugin

Converts your mkdocs documentation in PDF, to be shared with users
https://comwes.github.io/mkpdfs-mkdocs-plugin
GNU General Public License v3.0
103 stars 36 forks source link

Support WeasyPrint 53.0 #51

Open xkww3n opened 3 years ago

xkww3n commented 3 years ago

WeasyPrint 53.0 has changed the location of the module weasyprint.fonts file. Previously it was in .../weasyprint/fonts.py , but now it is in .../weasyprint/text/fonts.py. Could you please change the plugin to make it suitable for this version?

adamkusmirek commented 3 years ago

Since this is a breaking change for most systems (weasyprint 53.0 now requires at least libpango >=1.44) I'd argue that the best way of handling this would be pinning weasy to max v52.5 and including this into a patch release.

After that, for a new major release one could require Weasy >= 53 (which would not be downwards compatible of course)

At least in my fork I pinned the weasyprint version in setup.py for now since I cannot afford to upgrade the rest of my environment.

Ymil commented 3 weeks ago

Hi, this repository is not maintained, this fork (https://github.com/jurgenwigg/mkpdfs2-mkdocs-plugin) has compatibility with WeasyPrint 53.

I think it is reasonable to pinning the version of Weasy, WeasyPrint introduces changes to the interface once a month 😶.