search

con / centerforopenneuroscience.org

Website materials
http://centerforopenneuroscience.org
3 stars 25 forks source link

Introduce link checker #54

Closed asmacdo closed 4 weeks ago

asmacdo commented 1 month ago

@yarikoptic could you check if "Run workflows from fork pull requests" is enabled under Settings → Actions → General.

yarikoptic commented 1 month ago

I do not see such exact wording there. Made you admin so hopefully you could get to that interface yourself, can you?

asmacdo commented 4 weeks ago

I opened another PR from non-fork and suddenly this one started working :shrug:

asmacdo commented 4 weeks ago

@yarikoptic AFAICT there is no way to get the linkchecker to ignore the malformed email addresses. (which are malformed deliberately to avoid spam).

Even when we --ignore-url, it still checks the syntax and fails. 

URL        `mailto:mvdm at dartmouth dot edu'
Name       `E-Mail'
Parent URL file:///home/austin/devel/centerforopenneuroscience.org/output/whoweare.html, line 374, col 9
Real URL   mailto:mvdm%20at%20dartmouth%20dot%20edu
Info       The URL is outside of the domain filter, checked only
           syntax.
Result     Error: Missing `@' in mail address `mvdm'.

Option 1: fix email addr Option 2: remove email address button Option 3: try another tool

yarikoptic commented 4 weeks ago

Could you check/ file ticket for link checker?

asmacdo commented 4 weeks ago

https://github.com/linkchecker/linkchecker/issues/848

asmacdo commented 4 weeks ago

@yarikoptic got it. ready for review

yarikoptic commented 4 weeks ago

Great, thank you! I will deploy later