Re-enable osx tests - Githubissues

con / duct

A helper to run a command, capture stdout/stderr and details about running

MIT License

1 stars 1 forks source link

Re-enable osx tests #15

Closed asmacdo closed 3 weeks ago

asmacdo commented 2 months ago

https://github.com/con/duct/pull/14/files#diff-245392b692a50c38ecab4381b118862db514035c10983f3bd4f4b7f1f4be4692R27-R31

Disabled to keep the matrix small during development.

asmacdo commented 3 weeks ago

Tests failed on OSX 12 with python 3.8

Looks like the tmpdir fixture isn't working right? KeyError: 'USER'
Maybe some bad process/thread handling, but could also be bad exception handling of ^

mac_fail_ghaction.log

yarikoptic commented 3 weeks ago

odd, in principle there is USER variable on OSX

$> ssh datalads-imac2.kiewit.dartmouth.edu
Last login: Wed May 29 15:49:39 2024
yoh@datalads-imac2 ~ % export | grep USER
USER=yoh

but in general it would be more robust to use os.environ.get(X) instead of os.environ[X] so users do not get little tool blow into their faces happen tool's expectations of having some env vars not met.

asmacdo commented 3 weeks ago

+1, thats what I ended up doing.