con / duct

A helper to run a command, capture stdout/stderr and details about running
https://pypi.org/project/con-duct/
MIT License
3 stars 2 forks source link

Run precommit checks in CI #68

Open asmacdo opened 5 months ago

asmacdo commented 5 months ago

From @yarikoptic https://github.com/con/duct/pull/57#pullrequestreview-2107721418

Since you have it in pre-commit -- could have a pre-commit CI to check all of them if so was desired. here is a number of projects calling to pre-commit in their workflows -- didn't check yet for best example

here is a number of projects calling to pre-commit in their workflows -- didn't check yet for best example
❯ grep -l pre-commit */.github/workflows/*
aiohttp_retry/.github/workflows/python-package.yml
asv/.github/workflows/pre-commit.yml
belay/.github/workflows/pre-commit.yaml
black/.github/workflows/lint.yml
boto3/.github/workflows/lint.yml
briefcase/.github/workflows/ci.yml
briefcase/.github/workflows/pre-commit-update.yml
celery/.github/workflows/linter.yml
cibuildwheel/.github/workflows/test.yml
codecarbon/.github/workflows/pre-commit.yml
commitizen/.github/workflows/pythonpackage.yml
django-rest-framework/.github/workflows/pre-commit.yml
filesystem_spec/.github/workflows/main.yaml
gpt-engineer/.github/workflows/pre-commit.yaml
home-assistant/.github/workflows/ci.yaml
lark/.github/workflows/mypy.yml
lazy_loader/.github/workflows/lint.yml
mamba/.github/workflows/linters.yml
mdformat/.github/workflows/tests.yaml
mlflow/.github/workflows/autoformat.yml
mlflow/.github/workflows/lint.yml
mlflow/.github/workflows/recipe-template.yml
mypy/.github/workflows/test.yml
networkx/.github/workflows/lint.yml
nilearn/.github/workflows/update_precommit_hooks.yml
ome-zarr-py/.github/workflows/precommit.yml
pixi/.github/workflows/pre-commit.yml
prefect/.github/workflows/static-analysis.yaml
pydantic/.github/workflows/ci.yml
pydantic/.github/workflows/docs-update.yml
pyparsing/.github/workflows/pre-commit.yml
python-cookiecutter/.github/workflows/test.yml
requests/.github/workflows/lint.yml
ruff/.github/workflows/ci.yaml
ruff/.github/workflows/release.yaml
singularity-hpc/.github/workflows/main.yml
yarl/.github/workflows/reusable-linters.yml
zarr-python/.github/workflows/needs_release_notes.yml

asmacdo commented 3 months ago

See https://github.com/con/duct/pull/57#issuecomment-2156924092

yarikoptic commented 3 months ago

I might be slow but how that comment relates if in pre-commit we do not check README ?