search

con / duct

A helper to run a command, capture stdout/stderr and details about running
MIT License
1 stars 1 forks source link

Add dedicated `Arguments` type #87

Closed jwodder closed 2 weeks ago

jwodder commented 2 weeks ago

This will make type-checking easier later.

This PR builds on #85.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (313675d) to head (d4b1953). Report is 1 commits behind head on main.

Files Patch % Lines
src/duct.py 51.85% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== + Coverage 86.45% 86.79% +0.33% ========================================== Files 1 1 Lines 251 265 +14 Branches 39 41 +2 ========================================== + Hits 217 230 +13 - Misses 26 27 +1 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asmacdo commented 2 weeks ago

@jwodder might need to rebase this one, unless rebase and merge is smart enough to only include the last commit

asmacdo commented 2 weeks ago

well nevermind, rebase and merge is smart!