con / opfvta-reexecution

Container-based Replication of https://doi.org/10.1038/s41398-022-01812-5
Apache License 2.0
1 stars 1 forks source link

Numpy and Pandas in container #25

Closed TheChymera closed 1 year ago

TheChymera commented 1 year ago

For one of our latest figure generation scripts we will need the following software in the article-generating container:

(given proper dependency management, seaborn would pull in all 3, but proper specification would be to explicitly depend on all 3, since we call them directly).

@asmacdo, how could we best do this? I've had issues re-generating the image to include graphviz already.

asmacdo commented 1 year ago

@TheChymera I wouldn't explicitly install them if they are pulled in as dependencies, can you explain the problem?

If you do want to explicitly include them, we can pip install from the Container file, but as a rule of thumb, mixing pip installs with system installation can cause problems.

TheChymera commented 1 year ago

mixing pip installs with system installation can cause problems

Yep, I would agree.

can you explain the problem?

We import them explicitly in the script, so we shouldn't rely on the fact that we know seaborn pulls in all of them. It might stop doing so at some point. I mean it won't, but this is the sort of implicit magick which should be avoided in good dependency specification.

asmacdo commented 1 year ago

Fixed