search

con / tributors

Pay tribute to your contributors! A tool to automatically update contributor files.
https://con.github.io/tributors/
Apache License 2.0
13 stars 5 forks source link

mysterious user was added to datalad #53

Closed yarikoptic closed 3 years ago

yarikoptic commented 3 years ago

I guess would be tricky to figure out now how/why, but in https://github.com/datalad/datalad/commit/011cb1532d9edeba04bb60c41e8b73d28c8072bf 

$> git grep -i bhanupr        
.all-contributorsrc:            "login": "bhanuprasad14",
.all-contributorsrc:            "name": "bhanuprasad14",
.all-contributorsrc:            "profile": "https://github.com/bhanuprasad14",
.tributors:    "bhanuprasad14": {
.tributors:        "name": "bhanuprasad14",
.tributors:        "blog": "https://github.com/bhanuprasad14"
CONTRIBUTING.md:INFO:allcontrib:⭐️ Found new contributor bhanuprasad14 in .all-contributorsrc

was added but that user not longer exists on github, no activity reported in google cache for that login https://webcache.googleusercontent.com/search?q=cache:yAuBXNE0jawJ:https://github.com/bhanuprasad14+&cd=1&hl=en&ct=clnk&gl=us and I see no contributions via

$> git shortlog -sn | grep -i bhanu

or any issues for that login as harvested from git-bug: https://github.com/datalad/datalad-git-bug-dumps

but may be it is because this user no longer exists, but still I wonder what "code" contribution it was, and either I should start worry (that someone some code was injected somewhere with "fake" author entries (so no git shortlog -sn output)... may be you @vsoch still have somewhere that run/log somehow which could shine the light?

vsoch commented 3 years ago

I'm not sure, but if it's wrong I'd remove it. If the bug resurfaces, there would be a PR to add this mysterious author again. If the account is deleted then the commits are also no longer linked.

@yarikoptic this was almost a year ago! I definitely don't have any logs. If the entry is not re-generated I would chock it up to probably just a mistaken addition on my part.

yarikoptic commented 3 years ago

remained a mystery and I didn't want to act blindly to not miss some non-sanctioned commit in the history... searching for https://twitter.com/bhanuprasad14?lang=en lead me to https://github.com/phpbench/phpbench/blob/master/phpstan-baseline.neon which shows @bhanuprasad14 (which is no longer on github) being a contributor

image

but looking at history and commit https://github.com/phpbench/phpbench/commit/165e3fe13f2bb021f545feaf3ed9ffde4b2a8252#diff-995edee38ad4f8387e58ebd52c31bcc04c56cc2448d331b1cf5e0b35c57b9efa 

$> git log --format=full -- phpstan-baseline.neon | grep @ | sort | uniq -c
      5 Author: dantleech <dan.t.leech@gmail.com>
      1     Co-authored-by: My Name <test@example.com>
      5 Commit: GitHub <noreply@github.com>

it is either GitHub <noreply@github.com> or My Name <test@example.com> (from Co-authored-by:) which could have attributed to that! looking at https://github.com/con/tributors/pull/59/commits/581b16f6fe194c5338281b5d57a9cba67db26f4e where Michael was added by github, my wild guess is that we got this mysterious user because we did have that test@example.com someone, but it seems we didn't have that exact one and only

(git)lena:~datalad/datalad-master[master]git
$> git log --format=full | grep test@example.com

$> git log --format=full | grep .*@example.com  
Author: Neuroimaging Community <committer@example.com>
Author: Neuroimaging Community <committer@example.com>
Commit: Neuroimaging Community <committer@example.com>
Author: Neuroimaging Community <committer@example.com>
Commit: Neuroimaging Community <committer@example.com>
Author: Neuroimaging Community <committer@example.com>
Commit: Neuroimaging Community <committer@example.com>

... shortcut -- remembered about

$> grep example .mailmap 
Neuroimaging Community <committer@example.com> blah <committer@example.com> 
Neuroimaging Community <committer@example.com> <test@example.com> 
Neuroimaging Community <committer@example.com> unknown <test@nowhere.com>

, removed that file, and thus found https://github.com/datalad/datalad/blob/8dbb940ef6c18c8bd41e3405dd970b9a67f53655/after2.txt but there the fancy test@example.com was of committer, and it had a name, so didn't "allocate" to mysterious user.

Anyways -- mystery is not fully resolved, but I think it is due to use of test@example.com by that mysterious user at some point, and tributors likely finding that user matching that email address.