con / tributors

Pay tribute to your contributors! A tool to automatically update contributor files.
https://con.github.io/tributors/
Apache License 2.0
13 stars 6 forks source link

ideally order of new additions should be deterministic #56

Open yarikoptic opened 3 years ago

yarikoptic commented 3 years ago

I guess somewhere some set or unordered dict in place.

In datalad we got two PRs (since we didn't react to initial in time) for the "same" change: https://github.com/datalad/datalad/pull/5618 and https://github.com/datalad/datalad/pull/5622

I thought diffs would be identical and then the fix needs to be solely at the level of workflow but apparently there are differences in order:

1:  4e1365a77 ! 1:  59a016f50 Automated deployment to update contributors 2021-04-29
    @@ Metadata
     Author: github-actions <github-actions@users.noreply.github.com>

      ## Commit message ##
    -    Automated deployment to update contributors 2021-04-29
    +    Automated deployment to update contributors 2021-04-30

      ## .all-contributorsrc ##
     @@
    @@ .all-contributorsrc
     +            ]
     +        },
     +        {
    -+            "login": "mattcieslak",
    -+            "name": "Matt Cieslak",
    ++            "login": "mikapfl",
    ++            "name": "Mika Pflüger",
     +            "contributions": [
     +                "code"
     +            ],
    -+            "profile": "https://github.com/mattcieslak",
    ++            "profile": "https://github.com/mikapfl",
     +            "avatar_url": [
    -+                "https://avatars.githubusercontent.com/u/170026?v=4"
    ++                "https://avatars.githubusercontent.com/u/7226087?v=4"
     +            ]
     +        },
     +        {
    -+            "login": "mikapfl",
    -+            "name": "Mika Pflüger",
    ++            "login": "mattcieslak",
    ++            "name": "Matt Cieslak",
     +            "contributions": [
     +                "code"
     +            ],
    -+            "profile": "https://github.com/mikapfl",
    ++            "profile": "https://github.com/mattcieslak",
     +            "avatar_url": [
    -+                "https://avatars.githubusercontent.com/u/7226087?v=4"
    ++                "https://avatars.githubusercontent.com/u/170026?v=4"
     +            ]
              }
          ],
    @@ README.md: Sciences, Imaging Platform.  This work is further facilitated by the
     +    <td align="center"><a href="https://github.com/yetanothertestuser"><img src="https://avatars0.githubusercontent.com/u/19335420?v=4?s=100" width="100px;" alt=""/><br /><sub><b>yetanothertestuser</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=yetanothertestuser" title="Code">💻</a></td>
     +    <td align="center"><a href="https://github.com/bhanuprasad14"><img src="https://avatars3.githubusercontent.com/u/19843?v=4?s=100" width="100px;" alt=""/><br /><sub><b>bhanuprasad14</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=bhanuprasad14" title="Code">💻</a></td>
     +    <td align="center"><a href="https://github.com/christian-monch"><img src="https://avatars.githubusercontent.com/u/17925232?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Christian Mönch</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=christian-monch" title="Code">💻</a></td>
    -+    <td align="center"><a href="https://github.com/mattcieslak"><img src="https://avatars.githubusercontent.com/u/170026?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Matt Cieslak</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=mattcieslak" title="Code">💻</a></td>
     +    <td align="center"><a href="https://github.com/mikapfl"><img src="https://avatars.githubusercontent.com/u/7226087?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Mika Pflüger</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=mikapfl" title="Code">💻</a></td>
    ++    <td align="center"><a href="https://github.com/mattcieslak"><img src="https://avatars.githubusercontent.com/u/170026?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Matt Cieslak</b></sub></a><br /><a href="https://github.com/datalad/datalad/commits?author=mattcieslak" title="Code">💻</a></td>
     +  </tr>
     +</table>
     +