Closed yarikoptic closed 1 year ago
@vsoch ping -- any blessing or objections?
No objections! But if you are bringing in different linting, I'd recommend pre-commit https://github.com/koalaman/shellcheck-precommit and then add black/ isort and others there. I've been using it for most of my python projects and it's magical.
Not a hard requirement, just a suggestion for a nice developer experience. :sparkles:
yeah, we also use pre-commit in dandi-cli. I love and not it ;) someone might at some point in the future. Let's proceed with this for now as is.
Primarily constituted addressing two following warnings from shellcheck:
and for consistency I replaced all other uses of 'printf' with simple 'echo'.
Note:
tests/*.sh
were not treated and neither added to shellcheck workflow. Wanted first to assess if such changes are desired, can do similar act for tests if agreed to proceed.