search

con / tributors

Pay tribute to your contributors! A tool to automatically update contributor files.
https://con.github.io/tributors/
Apache License 2.0
13 stars 6 forks source link

Does action builds docker image every time it runs? #76

Closed yarikoptic closed 1 year ago

yarikoptic commented 1 year ago

I just saw that allcontributors-auto-detect in datalad repository workflow failed with

Build container for action use: '/home/runner/work/_actions/con/tributors/0.0.21/Dockerfile'.
  /usr/bin/docker build -t ed866e:be60600ffa[2](https://github.com/datalad/datalad/actions/runs/5191730431/jobs/9359936514#step:2:2)6408[3](https://github.com/datalad/datalad/actions/runs/5191730431/jobs/9359936514#step:2:3)ab4b2b48f65541e2 -f "/home/runner/work/_actions/con/tributors/0.0.21/Dockerfile" "/home/runner/work/_actions/con/tributors/0.0.21"
  Sending build context to Docker daemon  3.915MB
  ....
  Step 1/12 : FROM node:12
  12: Pulling from library/node
  f5196cdf2518: Pulling fs layer
  9bed1e86f01e: Pulling fs layer
  f[4](https://github.com/datalad/datalad/actions/runs/5191730431/jobs/9359936514#step:2:4)4e4bdb3a6c: Pulling fs layer
  2f7[5](https://github.com/datalad/datalad/actions/runs/5191730431/jobs/9359936514#step:2:5)d131f40[6](https://github.com/datalad/datalad/actions/runs/5191730431/jobs/9359936514#step:2:6): Pulling fs layer......
 Err:10 http://deb.debian.org/debian stretch/main amd64 Packages
    404  Not Found
  Ign:11 http://deb.debian.org/debian stretch-updates/main all Packages
  Err:12 http://deb.debian.org/debian stretch-updates/main amd64 Packages
    404  Not Found
  Reading package lists...
  W: The repository 'http://security.debian.org/debian-security stretch/updates Release' does not have a Release file.
  W: The repository 'http://deb.debian.org/debian stretch Release' does not have a Release file.
  W: The repository 'http://deb.debian.org/debian stretch-updates Release' does not have a Release file.
  E: Failed to fetch http://security.debian.org/debian-security/dists/stretch/updates/main/binary-amd64/Packages  404  Not Found
  E: Failed to fetch http://deb.debian.org/debian/dists/stretch/main/binary-amd64/Packages  404  Not Found
  E: Failed to fetch http://deb.debian.org/debian/dists/stretch-updates/main/binary-amd64/Packages  404  Not Found
  E: Some index files failed to download. They have been ignored, or old ones used instead.
  The command '/bin/sh -c /bin/bash -c "apt-get update && apt-get install -y wget bzip2 ca-certificates git &&     wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh &&     bash Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda &&     rm Miniconda3-latest-Linux-x86_64.sh"' returned a non-zero code: 100
...

but I am surprised that it tried to build it at all -- shouldn't it just fetch an image?

FWIW, according to https://github.com/datalad/datalad/actions/workflows/update-contributors.yml it started to fail over a month back.

vsoch commented 1 year ago

I ran into this too - for some reason that particular digest stopped working. I fixed it by updating to a master branch. My only guess is that there is some bug in GitHub.

vsoch commented 1 year ago

The trigger to build using a Dockerfile vs. use an image is here: https://github.com/con/tributors/blob/6b61be88354ba2ac1dc7a88a90fc1bac4ee6dc5a/action.yml#L50-L52

yarikoptic commented 1 year ago

well, the answer to the question -- yes, every time, but probably it is ok for now. master, and specifically tag 0.0.21-node-20 is fixed and could/should be used.