search

con / tributors

Pay tribute to your contributors! A tool to automatically update contributor files.
https://con.github.io/tributors/
Apache License 2.0
13 stars 6 forks source link

fix link to Contributors section #84

Closed crd477 closed 4 months ago

crd477 commented 1 year ago

Minor fix: the link included on the "all contributors" badge has a trailing "-" character that prevents navigating to the correct section.

I noticed this in a dependent repository, and naively tried to fix it there: https://github.com/USRSE/usrse.github.io/pull/1190 before realizing that it gets regenerated by the workflow: https://github.com/USRSE/usrse.github.io/pull/1191

crd477 commented 1 year ago

Hopefully this is the correct place to fix this, but I suppose it might also involve the upstream all-contributors.

vsoch commented 1 year ago

@crd477 the badge is entirely generated by all-contributors, so unfortunately there is nothing we can do here! In my experience, the dash usually shows up when the contributors section has an emoji, so try removing the emoji.

crd477 commented 1 year ago

Yeah, that's exactly what I observed. I noticed that they added that trailing emoji in https://github.com/all-contributors/all-contributors/commit/3f42985e8fcf732ba1bcea5b2648139ffdb660ea. I suppose I'll mention it as an issue for them. Thanks...

vsoch commented 1 year ago

I would also try adding the badge template explicitly, e.g., an example https://github.com/ruby-gh-actions/sandbox/blob/main/.all-contributorsrc