search

conan-io / cmake-conan

CMake wrapper for conan C and C++ package manager
MIT License
812 stars 247 forks source link

Don't issue "fatal errors" on unknown OS or compiler ID #227

Closed simfinite closed 3 years ago

simfinite commented 4 years ago

Hi all,

as Conan supports QNX now, I have been working on some preliminary QNX support over here.

Before going into details of supporting QNX, I would like to raise the question whether or not fatal errors should be issued on undetected OS or compiler IDs. The first thing I did in my QNX build experiments was to turn these fatal errors into warnings. When passing in all the toolchain details via a profile, it's very prohibiting to have the script error out just because the auto-detection fails. I am sure there are plenty other cases, especially in the embedded world, where this would apply. I found one already listed.

How about disabling the fatal errors when a specific profile is given?

czoido commented 4 years ago

Hi @simfinite, Thanks a lot for the suggestion, I'll open a PR to update the list of the host os's supported as is not reflecting all the ones that are supported by Conan. It also could make sense to change the ERROR to a WARNING for some cases but should not be needed if we update the supported os's list.

simfinite commented 4 years ago

Agreed.

Be aware that QNX is called QNX by CMake and Neutrino by Conan (see this commit)