search

conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
921 stars 1.66k forks source link

[request] itk/5.3.0 #15104

Open Nekto89 opened 1 year ago

Nekto89 commented 1 year ago

Package Name/Version

itk/5.3.0

Changelog

https://github.com/InsightSoftwareConsortium/ITK/releases/tag/v5.3.0

Context about the new update

The above-mentioned version is newly released by the upstream project and not yet available as a recipe. Please add this version.

poretga99 commented 1 year ago

I'd like to implement this version.

@SpaceIm Is it possible to work only on ITK 5.3.0 and deprecate/leave the ITK 5.1.x packages? Currently, they are not conanv2 compatible, but this project is quite big and it will take time to update old recipes & create a new one.

I was thinking of implementing something similar to Qt, where each version has its own .conf file, specifying modules and their dependencies?

SpaceIm commented 1 year ago

@SpaceIm Is it possible to work only on ITK 5.3.0 and deprecate/leave the ITK 5.1.x packages? Currently, they are not conanv2 compatible, but this project is quite big and it will take time to update old recipes & create a new one.

I'm not a conan team member, so I can't answer. You may want to ask to @uilianries @prince-chrismc @danimtb whether it's acceptable to drop the version which was the latest maintained, while migrating to conan v2.

I was thinking of implementing something similar to Qt, where each version has its own .conf file, specifying modules and their dependencies?

If internal dependencies are really different depending on itk versions, yes it's likely the way to go (see also the approach in boost recipe with its yaml files).

prince-chrismc commented 1 year ago

Just make a new recipe folder and call it "post-5.3.0" or something similar with a whole new recipes. We do not remove versions unless we have too, if you want to support a new version in 1.x and 2.0 that is totally fine

Ruwei commented 4 months ago

@poretga99 Have you got a working conan v2.0 recipe for 5.3.0? I'm new to both ITK & conan, looking for some guidance on writing such a recipe to build a package for my private artifactory repo. Thanks in advance for any help!

poretga99 commented 1 month ago

@Ruwei Due to the complexity of ITK's CMake configuration and multitude of the individual components, I did not proceed with the PR. I'm using the default ITKConfig.cmake which is prohibited by conan-center-index.