search

conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
978 stars 1.79k forks source link

[package] eigen/3.4.0: License configured in the Conan recipe does not match licenses in the licenses directory #15665

Open jwillikers opened 1 year ago

jwillikers commented 1 year ago

Description

Several licenses for Eigen are not listed for Eigen recipe's licenses attribute despite being applicable to the files distributed in the Conan package and being present in the licenses directory of the Conan package. Additionally, the MPL2_only option defines a macro which may effect compilation given something else doesn't interfere with it. The macro does not seem to actually effect the files shipped as part of the Conan package in the include directory. Therefore the licenses configured for the Conan package don't align with the source code shipped as part of the Conan package which is extremely confusing. I'm not sure how the Conan package should manage the licenses copied and configured for Eigen when the MPL2_only option is enabled. The Eigen package should properly declare all of the licenses it is subject to in the licenses attribute.

Package and Environment Details

Conan profile

[settings] [options] [conf] [build_requires] [env]

Steps to reproduce

$ conan inspect eigen/3.4.0 -a license
license: ('MPL-2.0', 'LGPL-3.0-or-later')
$ conan create recipes/eigen/all eigen/3.4.0@
$ ls ~/.conan/data/eigen/3.4.0/_/_/package/*/licenses/
COPYING.APACHE  COPYING.GPL   COPYING.MINPACK  COPYING.README
COPYING.BSD     COPYING.LGPL  COPYING.MPL2

Logs

Click to expand log ``` Put your log output here ```
SpaceIm commented 1 year ago

Some historic: https://github.com/conan-io/conan-center-index/pull/4342 https://github.com/conan-io/conan-center-index/pull/8723 https://github.com/conan-io/conan-center-index/issues/9428 https://github.com/conan-io/conan-center-index/pull/9571

I don't like this option and I think it was a big mistake.