Open db4 opened 1 year ago
czoido
commented
1 year ago Hi @db4,
We bumped the version in opencv because most of other libraries use 3.4.0 and it was forcing users to do overrides of the eigen version. Maybe you can try to override to 3.3.9 doing something like this in the consumer?
def requirements(self):
....
self.requires("eigen/3.3.9", override=True)
db4
commented
1 year ago Of course, I can override but that makes opencv unusable in existing recipes without special efforts. You don't support Visual Studio 2017 in CCI recipes anymore and don't build packages for it? Why this problem was not detected before your PR was merged?
jcar87
commented
1 year ago Hi @db4 - thank you for reporting this issue. We are looking into addressing this.
We have dropped support for Visual Studio 2017 from our CI service, as our our statistics suggest that Visual Studio 2019 and 2022 are overwhelmingly more used than the older 2017, and we continue to ramp up dedicated resources for building and validating packages for Conan 2.0, as previously announced: https://github.com/conan-io/conan-center-index/discussions/16729. Additionally, Visual Studio 2017 is past its mainstream support period from the vendor: https://learn.microsoft.com/en-us/lifecycle/products/visual-studio-2017.
Eigen 3.4.0 was released in late 2021, and given the time it has passed since, the changes in https://github.com/conan-io/conan-center-index/pull/17475 are entirely reasonable.
As you have pointed out, this appears to be a bug squarely within OpenCV or its use of Eigen. Thank you for providing a link to the upstream issue, we will look into addressing it. Please be mindful that the intention of Conan Center is not to validate all possible combinations of library and compiler versions, but to validate the ones that are known to work for the most popular platforms requested by our users.
We will look into this and work with the OpenCV community to troubleshoot this issue.
db4
commented
1 year ago @jcar87 If you dropped support for VS2017, OK I understand. But then why don't you build packages for VS2022? Actually, VS2019 is the only remaining CI build for Windows.
As for the bug, I could try to address it by applying the upstream fix, but CCI is in a strange state now. I have a trivial OpenCV-related PR that cannot be merged for several months. Right now CI complains about missing binaries, and there is nothing I can do about it. I know your resources are limited, but still...
AbrilRBS
commented
1 year ago But then why don't you build packages for VS2022?
Adding a new configuration at scale is not something that can happen overnight :(
Also note that even though it's not shown in PRs, VS2022 binaries do already exist for most libraries!
$ conan list "zlib/1.2.13:*#*" -r=conancenter -p "os=Windows AND compiler.version=193"
conancenter
zlib
zlib/1.2.13
revisions
e377bee636333ae348d51ca90874e353 (2023-04-27 12:11:24 UTC)
packages
17b26a16efb893750e4481f98a154db2934ead88
revisions
33077ea9977b39466f7a18cd58037321 (2023-05-17 10:14:33 UTC)
info
settings
arch: x86_64
build_type: Debug
compiler: msvc
compiler.runtime: dynamic
compiler.runtime_type: Debug
compiler.version: 193
os: Windows
options
shared: True
ed44dacde2751b398e4bf9441ff992a70c913c00
revisions
c64b86f291c5ebd9efb5c6fcdb20d7a7 (2023-05-17 10:13:12 UTC)
info
settings
arch: x86_64
build_type: Debug
compiler: msvc
compiler.runtime: dynamic
compiler.runtime_type: Debug
compiler.version: 193
os: Windows
options
shared: False
f7dcd1cec4586c154a242a765a1de011300db8e2
revisions
f301f1d89acb2e249bd3247ad764ab33 (2023-05-17 10:13:14 UTC)
info
settings
arch: x86_64
build_type: Release
compiler: msvc
compiler.runtime: dynamic
compiler.runtime_type: Release
compiler.version: 193
os: Windows
options
shared: True
7bfde258ff4f62f75668d0896dbddedaa7480a0f
revisions
6612117c7b5ed9d05294c47602331be1 (2023-05-17 10:13:10 UTC)
info
settings
arch: x86_64
build_type: Release
compiler: msvc
compiler.runtime: dynamic
compiler.runtime_type: Release
compiler.version: 193
os: Windows
options
shared: False
SpaceIm
commented
1 year ago Of course, I can override but that makes opencv unusable in existing recipes without special efforts. You don't support Visual Studio 2017 in CCI recipes anymore and don't build packages for it? Why this problem was not detected before your PR was merged?
This problem has been detected before, this is why I've never bumped eigen in opencv 3.x & 4.x recipes (see https://github.com/conan-io/conan-center-index/pull/17475#issuecomment-1540422416 and https://github.com/conan-io/conan-center-index/pull/8868#issuecomment-1011403488 and https://github.com/conan-io/conan-center-index/pull/8868/commits/812849459a27a2a11e752f41515f5ffe47dc1ac4). A condition could be added based on msvc version.
Description
That was done at https://github.com/conan-io/conan-center-index/pull/17475. Error:
See also https://github.com/opencv/opencv/issues/21675. Looks like you decided not to build VS2017 packages anymore, otherwise you would detect that in the PR CI pipeline.
Package and Environment Details
Conan profile
[settings] os=Windows os_build=Windows arch=x86_64 arch_build=x86_64 compiler=Visual Studio compiler.version=15 build_type=Release [options] [build_requires] [env]
Steps to reproduce
conan install opencv/4.5.3@ --build missing
Logs