Open lbckmnn opened 10 months ago
The only note I found was this: https://github.com/conan-io/conan-center-index/pull/3786#issuecomment-740049782
This is from 3 years ago, with the justification I'm guessing is that CCI only tested up to clang 9 at the time, and enough work went into fixing clang 9 that they assumed that no further version would work. So my guess is that really should be != 9 instead.
Is this something that could be changed? I would like to build the package using clang-15.
Also what is the purpose of a check like this? If it is not possible to build the library with a specific compiler, the build will just fail anyway.
Also what is the purpose of a check like this? If it is not possible to build the library with a specific compiler, the build will just fail anyway.
@lbckmnn I guess it is just easier to say it is not supported than actually dealing with complaints when it does not compile.
@Ahajha I can see in the original open62541 Repo that they also build with clang 11. Is it possible that this is not longer relevant for newer versions of open62541? How can I change the package or help to change it?
Also what is the purpose of a check like this? If it is not possible to build the library with a specific compiler, the build will just fail anyway.
@lbckmnn In the CI for this repo, it tries to build the package with various configurations, one of those being compiler version. It looks like currently it builds with clang 12 and 13 (of course you can build with others in theory, just these are checked and uploaded as binaries. Others must be built from source). If that configuration were to fail, it would be treated as a CI failure, so this is in place to make it known to CI that it will fail, so just skip it and treat as a "success". Of course, this can get out of sync, so there is always a goal to support the widest array of configurations.
@Kischy There is a contributing guide, but essentially you can fork and make a pull request. I believe you should be able to just remove the maximum clang version check, and that will automatically rebuild the packages.
@Ahajha Ok, I will do that. Is removing the version check the correct way to go? I would leave the check for open62541 versions below 1.3.8.
@Ahajha Could you have a look at https://github.com/conan-io/conan-center-index/pull/20892 and see why the CI runs fail? I can't access the logs...
Edit: I found the log. The Access Request approval is pending
@Ahajha Could you review PR https://github.com/conan-io/conan-center-index/pull/20892?
The recipe of open62541 allows only certain compiler versions. https://github.com/conan-io/conan-center-index/blob/3e1a99d8b04aa00b3c7563801710cd3cdb178e2b/recipes/open62541/all/conanfile.py#L218-L226
Is there any reason for that? the latest version seems to work just fine with clang16 and clang11 and I didn't find anything about this in the open62541 documentation.