conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
949 stars 1.73k forks source link

Add examples option to readline build (default disables installation of examples, fixes conan-io/conan-center-index/issues/24321) #24322

Closed paigeadelethompson closed 3 months ago

paigeadelethompson commented 3 months ago

Summary

Changes to recipe: readline/[all]

Motivation

Described in https://github.com/conan-io/conan-center-index/issues/24321

Details

Adds an option (defaults to True) for installation on examples (currently broken in https://git.savannah.gnu.org/git/readline.git master as well as readline-8.2 which is the latest used by Conan)


CLAassistant commented 3 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paige Thompson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

conan-center-bot commented 3 months ago

Conan v1 pipeline :x:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details: Sorry, the build is only launched for Access Request users. You can request access [writing in this issue](https://github.com/conan-io/conan-center-index/issues/4).
paigeadelethompson commented 3 months ago

Sorry, the build is only launched for Access Request users. You can request access https://github.com/conan-io/conan-center-index/issues/4.

I'll let somebody else take over this, feel free I'm able to make do with conan export for now

jcar87 commented 3 months ago

Sorry, the build is only launched for Access Request users. You can request access #4.

I'll let somebody else take over this, feel free I'm able to make do with conan export for now

Hi @paigeadelethompson - thank you for your contribution! Absolutely, we can take care of the CI bit ourselves - however the CLA is still required for us to move forward: https://cla-assistant.io/conan-io/conan-center-index?pullRequest=24322

We are working to streamline the Pull Request process and in the future "requesting access" will not be a requirement.

AbrilRBS commented 3 months ago

Closing in favour of https://github.com/conan-io/conan-center-index/pull/24350, thanks for the heads-up, we can take it form here, but I'd appreciate if you could answer my question in the linked PR @paigeadelethompson, thanks!

paigeadelethompson commented 2 weeks ago

@AbrilRBS hi,

authorized the CLA for future purposes I may have a couple of packages worth submitting in the near future