search

conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
949 stars 1.73k forks source link

Pixman: Supply cpu-features-path meson option. Required to build for Android-armv7 #24375

Closed ViliusSutkus89 closed 3 months ago

ViliusSutkus89 commented 3 months ago

Summary

Changes to recipe: pixman/0.43.4

Motivation

Pixman build for Android armv7 looks for the cpu-features.h header, which usually is supplied by the NDK. Without this patch Pixman does not compile for Android armv7.

Details

Pixman's meson build accepts option which tells it where to look for cpu-features.c and cpu-features.h . This patch does exactly just that.

I am aware of #8011 , but it is not merged, and I assume that Pixman's source code too would need to be patched to take a different library, while my suggested patch just supplies the correct meson option and Pixman just works then.

Even with this patch, older versions of pixman (0.43.0 and 0.42.2) are still build broken for Android armv7, but I am not too concerned with them, because they were buildbroken before this patch too.

Link to a CI run with proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563222408 Link to a CI run without proposed patch - https://github.com/ViliusSutkus89/conan-odr-index/actions/runs/9563286270 Note how pixman/0.43.4 - android-armv7 turns green

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

conan-center-bot commented 3 months ago

Conan v1 pipeline :x:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

ViliusSutkus89 commented 3 months ago

I'm using conan 2.4.1 . This means the the recipe works on conan v2.

Is this error about required_conan_version = ">=1.53.0" in the conanfile.py?

conan-center-bot commented 3 months ago

Conan v1 pipeline :heavy_check_mark:

All green in build 2 (e0efa7d3f84b0456ac39c44953499b442a9a916c):

Conan v2 pipeline :heavy_check_mark:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (e0efa7d3f84b0456ac39c44953499b442a9a916c):

ViliusSutkus89 commented 3 months ago

You're welcome. I had to do a CI compile anyways to make sure the patch works, so posting the logs wasn't a big deal