conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
918 stars 1.65k forks source link

bgfx: add new version and consolidated recipe #24423

Open RazielXYZ opened 5 days ago

RazielXYZ commented 5 days ago

Summary

Changes to recipe: bgfx

Motivation

This adds a consolidated recipe for bgfx going forward. This is versioned using bgfx' versioning scheme (https://github.com/bkaradzic/bgfx/blob/93961afcfd45bdcbdb91bddfb133a621d340f136/src/bgfx.cpp#L3566), and integrates bx and bimg into this package. This was done after discussions about whether having bx and bimg separate is valuable, and how due to their interdependence, need for dependency sources, and reliance on specific versions, having them separate makes updates on CCI much slower and more cumbersome.

Details

The recipe is still based on the previous bgfx recipe, but with quite a few changes and additions. It adds all things required for bimg and bx to be integrated into this recipe, such as defines, libs, and their headers. It also adds an option for rtti, due to the fact that bgfx' (and bx', and bimg's) build scripts are hardcoded to build with rtti disabled. Packages on CCI are rtti enabled by default, and mixing these can cause linker issues, especially on linux in my experience. There is also improved support for mingw and android, changes to make other things more consistent, and so on. The new recipe has been locally tested on windows 11 msvc194 and mingw, linux gcc, and android.

Some questions I was pondering: Would there be value in adding an option for overriding bx' CRT detection in order for this to build with something like musl? Would there be value in exposing options for opengl version etc. and other compile-time options that bgfx has?


conan-center-bot commented 5 days ago

Conan v1 pipeline :x:

Failure in build 1 (9b360b27556d0df4cfcf76c47cc4b97b2b2a7ca8):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 1 (9b360b27556d0df4cfcf76c47cc4b97b2b2a7ca8):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

RazielXYZ commented 5 days ago

This needs osx >= 13, how do we limit it to that? Looks like it's trying to use 11.3 and the cci profiles do not provide os.version or os.sdk_version for osx, it seems

conan-center-bot commented 5 days ago

Conan v1 pipeline :x:

Failure in build 2 (df89034560c73be9e3d4d61e0ad907b991b3662d):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 2 (df89034560c73be9e3d4d61e0ad907b991b3662d):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-center-bot commented 5 days ago

Conan v1 pipeline :x:

Failure in build 3 (c6715c1878f447ce32ffe301dcf5bf6a5fb19571):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (c6715c1878f447ce32ffe301dcf5bf6a5fb19571):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

RazielXYZ commented 5 days ago

On conan 1, it still doesn't seem to use C++17 even with setting tc.cppstd = "-std=c++17" manually. I'm guessing tc.generate() overwrites it from self.settings? On mac, I guess we might need to skip macos builds on cci for now if the agents' macos sdk is too old.

conan-center-bot commented 3 days ago

Conan v1 pipeline :x:

Failure in build 4 (14b13c5ec1dfeb0e6dd6a89950435b0bf1173914):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 4 (14b13c5ec1dfeb0e6dd6a89950435b0bf1173914):


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.