Qt5: fix incorrectly added qtaudio_alsa and gstcamerabin plugin libs

valgur commented 3 months ago

Summary

Changes to recipe: qt/5.x.x

Motivation

qt/5.15.14 with default options and */*:shared=False fails during find_package() in consuming projects due to qtaudio_alsa and gstcamerabin library files not being found.

These two plugins are always added on Linux in the conanfile. However, they are only enabled in the Qt5 project files if libalsa and gstreamer are available: https://github.com/qt/qtmultimedia/blob/v5.14.2/src/plugins/plugins.pro#L47-L59

Details

Only add these plugins when with_libalsa and with_gstreamer are enabled, respectively, as a fix.

This has probably not been caught by the CI due to the "essential_modules": not os.getenv('CONAN_CENTER_BUILD_SERVICE') default, which disables qtmultimedia.

[x] Read the contributing guidelines
[x] Checked that this PR is not a duplicate: list of PRs by recipe
[x] Tested locally with at least one configuration using a recent version of Conan

conan-center-bot commented 3 months ago

Conan v1 pipeline :heavy_check_mark:

All green in build 1 (e25b2eb62beffd1c64a96d549e1a876d6e373672):

qt/5.15.14: All packages built successfully! (All logs)

Conan v2 pipeline :x:

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 1 (e25b2eb62beffd1c64a96d549e1a876d6e373672):

qt/5.15.14: An unexpected error happened and has been reported

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions[bot] commented 3 months ago

Hooks produced the following warnings for commit e25b2eb62beffd1c64a96d549e1a876d6e373672

qt/5.15.14@#2f198711c78cbd48c2d1c54472c0e40e

``` post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\libGLESv2d.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\libGLESv2.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Cored.dll' links to system library 'mpr' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2dd.dll' links to system library 'dwrite' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2dd.dll' links to system library 'd2d1' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Guid.dll' links to system library 'dxgi' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Guid.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2dd.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\sqldrivers\qsqlodbcd.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2d.dll' links to system library 'd2d1' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\sqldrivers\qsqlodbc.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Core.dll' links to system library 'mpr' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Gui.dll' links to system library 'dxgi' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Gui.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2d.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs. post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\plugins\platforms\qdirect2d.dll' links to system library 'dwrite' but it is not in cpp_info.system_libs. ```

conan-center-bot commented 3 months ago

Conan v1 pipeline :heavy_check_mark:

All green in build 2 (e25b2eb62beffd1c64a96d549e1a876d6e373672):

qt/5.15.14: All packages built successfully! (All logs)

conan-io / conan-center-index