conan-io / conan-center-index

Recipes for the ConanCenter repository
https://conan.io/center
MIT License
945 stars 1.71k forks source link

[docs] Add a policy about patching #3903

Closed danimtb closed 2 years ago

danimtb commented 3 years ago

Related to the discussion at https://github.com/conan-io/conan-center-index/pull/3834

We should all agree on some general policy around source code patches in libraries.

To start the conversation I would add the following points:

Patches are allowed to when:

  • They are related to solving any kind of vulnerability.
  • They apply to build system files or build scripts.
  • They allow libraries to build in other configurations.
  • They improve the integration with Conan. e. g. making the package more portable, integrating with other dependencies...
  • They patch the source code of a library that is no longer maintained or not willing to take the patch upstream.

Patches are not allowed when:

  • They purely modify the library's source code that modifies the behavior of the library (except the is a declared vulnerability).
  • They don't contribute to make the package more portable or make the library build in other configurations.

Those are just first thoughts, so feedback is welcomed.

Croydon commented 3 years ago

I welcome this. #3834 is not the first time that we had discussions if it is okay to apply certain patches or not. Having a policy will certainly help.

I mostly agree with the points above, but I would also like to keep the door open for back porting of reasonable large patches (which I guess is hard to define) which fix bugs in the libraries/tools, when those are already accepted upstream and will be part of a next release. Sometimes it can take a year or longer for new releases to come and if there is already an accepted solution which might be easily portable (e.g. only very few line changes) then I don't see a reason why we should deny this in principal. I would then leave it to the educated guess / feeling of the reviewers if something looks reasonable or not.

If the project is getting maintained but a patch is not accepted (yet), then there is probably a good reason and we should not apply the patch.

They patch the source code of a library that is no longer maintained

I agree with this first part

or not willing to take the patch upstream.

But not with this one. I think we have to differ

prince-chrismc commented 3 years ago

Croydon, would if be fair to summarize your position as "follow as upstream does"?

If the patch was accepted and merged into the default branch, it could just be a virtual version as well? I think this would prevent consumer from having unwanted surprises.

a4z commented 3 years ago

you do not seriously want starting to discuss if it is OK to add a patch that fixes a clear bug in a package that prevent the package to work properly? what is a reason that seems to be missing in your lists, @danimtb

because if you think bugfixes are no reason for a patch than I will stop immediately use cci and work on the packages I am interested in my own fork.

therefore, patching of builds, without providing the changes upstream to the original source, this is really bad practice! As can seen in the referred package with it's massive build file patch. Btw, I actually wanted to be helpful in this respect, see https://github.com/eclipse/paho.mqtt.c/issues/1017 , because I think getting rid of that insane cmake patch in the named package should be easy, maybe not much more time than I wasted thought that unbelievable hostile reaction and pointless discussions on this patch issue. But there are projects that are welcoming, and such that are not and I will focus on such that are.

Unbelievable what this ridiculous reaction of a library author who felt piss off because someone touched his 'private recipe' caused for a waste of energy. The whole discussion was clearly not for technical reasons, because technically there is zero value in the complains.

and btw, #3834 has still no review and is hanging. a good way of demotivating people that share work. so imho, energy could have been spent better than opening that issue

jgsogo commented 3 years ago

Hi! From the POV of a package manager we cannot modify the behavior of a library when the reference matches a released version. We shouldn't add patches that fix bugs or add/modify features, otherwise the packaged binary will no longer match the expectations of the released library, it will no longer match the changelog and, it can be very confusing to consumers and to library authors if issues start to arrive to the upstream repository. If we add patches, we will add one today and one tomorrow, and different recipe revisions will behave differently.

Vulnerabilities are a different kind of patches, we can talk about them in a different way.

When the upstream library is not maintained or there is strong evidence that it will take too long to release a new version with some pending patches, my suggestion would be to create a new version based on an existing one and apply patches to it. That way, the canonical reference will match the released library (with its bugs, that some project might be using like actual features) and this new version can contain patches that have been already submitted/merged for the next release in the upstream repository.

We already have cci.<date> versions for releases that only exist in ConanCenter, let's use something similar here too, but add the base version somehow: cci.<base-version> (zlib/1.2.11 -> zlib/cci.1.2.11). We should take into account that this cci.<base-version> version will contain all patches available, so it is not going to be a stable release, it might get new bugfixes/features... it is important it doesn't satisfy semver.

danimtb commented 3 years ago

sorry to bother you @a4z but I opened this issue to collect some feedback about the points above and try to reach some consensus around patching in recipes.

First of all, I would like to clearly state that we consider all the views whenever we discuss a topic, no matter if they are coming from advanced Conan users, beginners, library authors, recipe contributors... Everyone will always be welcomed with constructive feedback because is the only way to make a project like Conan and ConanCenter work.

Secondly, here I was talking about general policy and I am not talking about the specific case in #3834. In fact, I strongly believe that the discussion happened because we did not have this kind of policy and as @Croydon mentioned, it is something needed at this point.

Specifically talking about patches for bugfixes, we all know that there are always bugs in software and it is something we have to live with. However, I can also see the pain in changing the behavior (even if it is a bugfix) for someone that is relying somehow on it. I am not saying that we should not patch things, I am saying that we should set a common ground in the conan-center-index so everyone knows what to expect then they consume a package from ConanCenter. This means that there are patches that everyone could benefit from based on these rules and probably other ones that certainly will have to be maintained in forks.

So finally, to answer the last point, I don't think #3834 is a waste of time. In fact, it helped to start this discussion and it will eventually help to review the PR with common criteria from the reviewers.

a4z commented 3 years ago

if things like in #3834 will not be applied, cci becomes worthless for production, because as paho-mqtt-c is now in cci it is unusable if you have a certain mqtt workflow !

and if you think this is cool, this means the few people that actually do notifying you about such problems will stopp bother.

and then you do not need to wonder when you not get any fee back from user that are normally in a less open space (company) than the opens source space, because for getting this you need to be able to distribute working software

form that blog

Many of these developers either can’t engage with the community due to company policy, or choose not to for other reasons. from https://blog.conan.io/2020/12/01/Moving-Conan-20-tribe-forward.html

Insist on shipping of non working software via the cci and create more other reasons

In none of the changelog or howto or what ever of paho-mqtt-c was mentioned that the current behaviour is like the bug does, quite the opposite is the case, it should work, and with the patch it does as announced. That the library author of paho-mqtt-c seems to be a special case who creates noise and apple banana comparisons should not distract you, other library authors would have said thank you, and would have be welcoming for the offered help.

So sorry Javier, what you write makes no sense. at all. And it is not as reality works, please look at various packages in Linux distributions, and see what they patch. Reality wants working software!

And you do not bother me Daniel, add this policy, make it clear that you reject to deliver working software and prefer to ship software with known bugs via cci , and you will spare me quite some time in future, and that is good to know.

SSE4 commented 3 years ago

something to consider:

solvingj commented 3 years ago

Good data @SSE4 I only want to talk specifically about the top-level policy first:

Should conan make the guarantee to only use official upstream sources? 

Discussing "categories of patches" only matters if we decide "some patching" will occur.

Quick points on theory:

Quick points on practice:

User Expectations: We should also talk about what users do expect today, should expect, and how they should derive their expectation right now. Obviously, "what users expect today" is a spectrum and we'd like to narrow that spectrum so that our user base as a whole has the most consistent expectations possible. What those expectations should be we can only influence and not guarantee or enforce. People will misinterpret, etc. Thinking about how we can influence, I think we should consider people's context for deriving expectations.

What context do users have to derive expectations about the binaries right now?  (sources, patches, compiler flags)

It's reasonable to say that most users today have the most of the following context:

I think our top priority right now should be to ensure that when users do research, they can easily find clear explanations on what the policies are (whatever we decide them to be). Then, whether we patch or not, users can make informed decisions.

Clarifying policy: I think in any case, there's at least one obvious takeaway here. The overall policy and intended use cases and scope for Binaries coming from Conan Center Index deserves clear and public clarification. Even internally, the Conan team members seem to have substantially different views about which goals (which users and use cases) are in scope, and which goals are not.

There's obvious opportunity to add statements to CCI readme, conan center index web page, search results, etc. Additionally, I would suggest starting a discussion somewhere around adding code (potentially hooks), which outputs policy and disclaimers in the CLI output whenever packages are installed from Conan Center Index. Maybe even when they're consumed.

a4z commented 3 years ago

good you mention the theory of "Only official sources ever" , @solvingj because #3834 fulfils that, for the patch I added, not the patches of the cmake things. since I created the patch for official sources.

still, my change is under discussion and now frozen and topic of bureaucracy and has after days no review because of a special lib author whose comment should be deleted, and I regret heavily pinging this individual for a review, since he clearly misses competence on the topic software delivery, because if he would have some, he either accepted the patch on the package happily, or release an new minor version of his buggy software quickly containing the patch. but nothing of that happened, and the cci still ships a known to non fully working package of paho-mqtt-c. awesome.

so, anyone here involved once to give #3834 a positive review, after seeing that this would of course also work for ubunut, yocto and ot her things that have some idea about packaging and delivering software, in opposite to the author of the effected library, and after seeing what a internal small thing that patch is, and that this is even accepted for the next version without discussion.....

prince-chrismc commented 3 years ago

Firstly I apologize that you have recently had a rough time with your PRs. I absolutely understand it can be frustrating. Working with the community for a few months now and I want to assure we take your contributions unequivocally as all others.

Now to address your comments

and has after days no review...

This is very common. Right now there is an above average number of pull requests open. I personally have some that have not been reviewed and other getting stale like #3711.

Absolutely every contribution is being affected by a slow down.

...because of a special lib author

On my behalf, I am not with holding my review because of the comments by any individual. I need the topic at large needs to have a consensus before being able to move forward. I do not believe my opinion should be the basis for a review but rather an objective qualification of the work presented. At this time I do not feel I can meet that standard.

after seeing that this would of course also work for ubunut, yocto and other things that have some idea about packaging and delivering software

I love human perspective.

I read those links shared and a few others from searching quickly, and I am under the perception that your changes are not accepted by those package managers.

pov

a4z commented 3 years ago

I love human perspective.

I read those links shared and a few others from searching quickly, and I am under the perception that your changes are not accepted by those package managers.

From Ubuntu: Sometimes, Ubuntu package maintainers have to change the upstream source code in order to make it work properly on Ubuntu. Examples include, patches to upstream that haven’t yet made it into a released version, ... we keep these changes as separate patches, in the form of diff files

what is exactly the use case!

And I know about patches that made in into corporate, kind of proprietary, yocto Linux dists that run on system that need certifications, to give you your company background also, but you will have of course your own human perspective ;-)

so feel free to create your interpretations as you wish. No wonder there is a stack of open PRs if time is invested in issues like that. Copy the Ubuntu rules, and stop shipping software with known bugs by rejecting fixes via the cci. It can be that easy.

SSE4 commented 3 years ago

vcpkg's policy: https://github.com/microsoft/vcpkg/blob/master/CONTRIBUTING.md#new-package-guidelines https://github.com/microsoft/vcpkg/blob/master/docs/examples/patching.md

a4z commented 3 years ago

meanwhile in the cci , 9 days of shipping software with known bug instead of applying an easy fix. any more questions why cci becomes unusable for serious/commercial/industrial projects?

a4z commented 3 years ago

good luck reviewing all the, and throw out those packages that patch source code, or remove the patches that modify the code :-)

an other prove that you are just confused by the bite reaction of a person who took it personal that someone worked on his recipe, and tried to confuse you with world most stupid arguments on that topic

@jgsogo , I think it is time you ack my PR. Or, remove all recipes with patches that modify code. I found some where the changes are more massive and complex than the very clear and simple patch I added #3834 . Or shall I think you apply double standards?

Here a list with all patches, enjoy the review :) Maybe Ian can help you , since he is the cause of your confusion and all the mess ;-)

find conan-center-index/recipes -name "*.patch"
conan-center-index/recipes/edlib/all/patches/cmake-install-and-export-symbols.patch
conan-center-index/recipes/libpqxx/all/patches/0001-cmake-fix-module.patch
conan-center-index/recipes/libpsl/all/patches/0001-0.21.2-meson-no-tests.patch
conan-center-index/recipes/botan/all/patches/fix-unrecognized-linker-flag.patch
conan-center-index/recipes/botan/all/patches/vs2015-install-fix.patch
conan-center-index/recipes/botan/all/patches/dll-dir.patch
conan-center-index/recipes/cppbenchmark/all/patches/00001-update-cmakelists.patch
conan-center-index/recipes/cjson/all/patches/fix-cmake-install.patch
conan-center-index/recipes/easylzma/all/patches/memleaksfix.patch
conan-center-index/recipes/easylzma/all/patches/cmake-no-cflags.patch
conan-center-index/recipes/libgd/all/patches/2.2.5-msvc-static-lib.patch
conan-center-index/recipes/libgd/all/patches/2.2.5-qualify-nondll.patch
conan-center-index/recipes/libgd/all/patches/remove-unistd-h.patch
conan-center-index/recipes/libgd/all/patches/qualify-nondll.patch
conan-center-index/recipes/etc2comp/all/patches/fix-cmake.patch
conan-center-index/recipes/z3/all/patches/0001-cmake-use-conan-mpir.patch
conan-center-index/recipes/libdb/all/patches/0001-rename_atomic_compare_exchange.patch
conan-center-index/recipes/libdb/all/patches/0004-msvc-tcl-include-conanbuildinfo-props.patch
conan-center-index/recipes/libdb/all/patches/0002-no-conditional-tcl-include.patch
conan-center-index/recipes/libdb/all/patches/0003-msvc-db_tcl-add-static-configuration.patch
conan-center-index/recipes/ceres-solver/all/patches/1.14.0-0001-find-libraries-conan.patch
conan-center-index/recipes/ceres-solver/all/patches/1.14.0-0002-fix-msvc-c++17.patch
conan-center-index/recipes/ceres-solver/all/patches/2.0.0-0001-find-libraries-conan.patch
conan-center-index/recipes/proj/all/patches/fix-mingw-target-clones.patch
conan-center-index/recipes/proj/all/patches/use-cmake-targets-7.0.x.patch
conan-center-index/recipes/proj/all/patches/fix-cmake-include-dir.patch
conan-center-index/recipes/proj/all/patches/use-cmake-targets-6.x.x.patch
conan-center-index/recipes/proj/all/patches/use-cmake-targets-7.1.1.patch
conan-center-index/recipes/proj/all/patches/use-cmake-targets-7.2.0.patch
conan-center-index/recipes/proj/all/patches/use-cmake-targets-7.1.0.patch
conan-center-index/recipes/proj/all/patches/fix-build-gcc-lessthan-5.patch
conan-center-index/recipes/capnproto/all/patches/0004-cmake-module-path.patch
conan-center-index/recipes/capnproto/all/patches/0005-msvc-16.7-ice-workaround.patch
conan-center-index/recipes/capnproto/all/patches/0001-disable-tests.patch
conan-center-index/recipes/capnproto/all/patches/0003-kj-tls-windows.patch
conan-center-index/recipes/capnproto/all/patches/0002-cmake-compat-header-install.patch
conan-center-index/recipes/libheif/all/patches/0001-cmake.patch
conan-center-index/recipes/libtiff/all/patches/4.0.8-0001-cmake-add-libjpeg-turbo.patch
conan-center-index/recipes/libtiff/all/patches/4.1.0-0001-cmake-add-libjpeg-turbo.patch
conan-center-index/recipes/libtool/all/patches/0001-libtool-relocatable.patch
conan-center-index/recipes/libtool/all/patches/0002-libtool-fix-type-libtool.patch
conan-center-index/recipes/geos/all/patches/fix-cmake-3.8.0.patch
conan-center-index/recipes/geos/all/patches/fix-cmake-3.8.1.patch
conan-center-index/recipes/tinycbor/all/patches/conan.patch
conan-center-index/recipes/gmp/all/patches/6.1.x-0001-fix-MSVC-next-prime-error.patch
conan-center-index/recipes/gmp/all/patches/6.2.x-0001-fix-MSVC-next-prime-error.patch
conan-center-index/recipes/gmp/all/patches/6.1.x-0002-fix-MSVC-debug.patch
conan-center-index/recipes/gmp/all/patches/0001-msvc-dumpbin-yasm-wrapper.patch
conan-center-index/recipes/rocksdb/all/patches/6.10.2/0001-Rename-jemalloc-according-to-conan-packages.patch
conan-center-index/recipes/rocksdb/all/patches/6.8.1/0001-Rename-jemalloc-according-to-conan-packages.patch
conan-center-index/recipes/easyhttpcpp/all/patches/0001-allow-inclusion-as-subproject.patch
conan-center-index/recipes/cppcheck/all/patches/0001-cmake-source-dir.patch
conan-center-index/recipes/libiconv/all/patches/0001-libcharset-fix-linkage.patch
conan-center-index/recipes/amqp-cpp/all/patches/0001-cmake-openssl-install-directories.patch
conan-center-index/recipes/enet/all/patches/fix-cmake.patch
conan-center-index/recipes/json-c/all/patches/fix-cmake-0.13.1.patch
conan-center-index/recipes/json-c/all/patches/fix-exported-symbols-0.13.1.patch
conan-center-index/recipes/ogg/all/patches/001-fix-unsigned-typedefs-for-macos.patch
conan-center-index/recipes/lzip/all/patches/0001-any-compiler.patch
conan-center-index/recipes/libidn2/all/patches/0001-no-versioning-of-symbols.patch
conan-center-index/recipes/qr-code-generator/all/patches/001-qrcode-1_4.patch
conan-center-index/recipes/qr-code-generator/all/patches/002-cmake-extra-files-1.4-1.5.patch
conan-center-index/recipes/libuuid/all/patches/0001-Check-for-HAVE_SYS_SYSCALL_H.patch
conan-center-index/recipes/meshoptimizer/all/patches/0.14/001_Fix build_on_old_AppleClang_versions.patch
conan-center-index/recipes/g3log/all/patches/0001-remove-explicit-stdlib-setting.patch
conan-center-index/recipes/g3log/all/patches/0002-remove-explicit-stdlib-setting.patch
conan-center-index/recipes/opencolorio/all/patches/1.1.1.patch
conan-center-index/recipes/czmq/all/patches/0001-allow-cmake-subproject.patch
conan-center-index/recipes/czmq/all/patches/0004-make-czmq-link-using-cxx-compiler.patch
conan-center-index/recipes/czmq/all/patches/0003-fix-cmake-find-package.patch
conan-center-index/recipes/czmq/all/patches/0002-dont-build-zmakecert.patch
conan-center-index/recipes/dataframe/all/patches/0001-remove-tests-bin-for-conan-package.patch
conan-center-index/recipes/mfast/all/patches/00001-adapt-cmakelists.cci.20200824.patch
conan-center-index/recipes/mfast/all/patches/00004-remove-cxx-std.cci.20200824.patch
conan-center-index/recipes/mfast/all/patches/00001-adapt-cmakelists.patch
conan-center-index/recipes/mfast/all/patches/00002-add-conan-libs-to-targets.patch
conan-center-index/recipes/mfast/all/patches/00003-remove-deprecated-boost-detail-endian.cci.20200824.patch
conan-center-index/recipes/mfast/all/patches/00002-add-conan-libs-to-targets.cci.20200824.patch
conan-center-index/recipes/mfast/all/patches/00003-remove-deprecated-boost-detail-endian.patch
conan-center-index/recipes/websocketpp/all/patches/websocket_boost_support_1_7_x.patch
conan-center-index/recipes/shaderc/all/patches/2019.0/fix-spvc.patch
conan-center-index/recipes/shaderc/all/patches/2019.0/fix-cmake.patch
conan-center-index/recipes/zyre/all/patches/0001-cmake-use-conan-disable-executables.patch
conan-center-index/recipes/zyre/all/patches/0003-fix-zyre-self-test-on-windows.patch
conan-center-index/recipes/zyre/all/patches/0002-zyre-disable-git-escape-CMAKE_BUILD_TYPE.patch
conan-center-index/recipes/bdwgc/all/patches/update-cmake.patch
conan-center-index/recipes/fruit/all/patches/0002-remove-cmake-extra-target-3.6.0.patch
conan-center-index/recipes/fruit/all/patches/0001-fruit-3.4.0-cmake.patch
conan-center-index/recipes/fruit/all/patches/0002-remove-cmake-extra-target-3.5.0.patch
conan-center-index/recipes/fruit/all/patches/0003-supports-cmake-multi-configuration-generator.patch
conan-center-index/recipes/fruit/all/patches/0004-set-options-for-cmake-target.patch
conan-center-index/recipes/libtommath/all/patches/0001-enable-building-dll-s-using-makefile-msvc.patch
conan-center-index/recipes/swig/all/patches/0002-4.0.1-do-not-define-SWIG_LIB_WIN_UNIX.patch
conan-center-index/recipes/swig/all/patches/0002-4.0.2-do-not-define-SWIG_LIB_WIN_UNIX.patch
conan-center-index/recipes/swig/all/patches/0001-swig-linux-library-path.patch
conan-center-index/recipes/flann/all/patches/external-lz4-and-export-symbols.patch
conan-center-index/recipes/libjpeg/all/patches/0001-libjpeg-add-msvc-dll-support.patch
conan-center-index/recipes/libpng/all/patches/CMakeLists-zlib.patch
conan-center-index/recipes/tinyexr/all/patches/0001-use-conan-deps.patch
conan-center-index/recipes/ncurses/all/patches/0003-Do-not-redeclare-exit.patch
conan-center-index/recipes/ncurses/all/patches/0010-Pass-BUILDING_XXX-compile-definition-while-building-.patch
conan-center-index/recipes/ncurses/all/patches/0014-avoid-macro-expansion-in-args-by-defining-NCURSES_NO.patch
conan-center-index/recipes/ncurses/all/patches/0018-missing-functions-c-linkage.patch
conan-center-index/recipes/ncurses/all/patches/0004-fix-win32con.patch
conan-center-index/recipes/ncurses/all/patches/0001-Look-for-pcre2posix-instead-of-pcre2-posix.h.patch
conan-center-index/recipes/ncurses/all/patches/0019-Run-autoreconf.patch
conan-center-index/recipes/ncurses/all/patches/0011-Let-each-sublibrary-do-its-own-import-exporting.patch
conan-center-index/recipes/ncurses/all/patches/0016-msvc-has-wchar-support.patch
conan-center-index/recipes/ncurses/all/patches/0005-api-must-be-placed-next-to-variable-name.patch
conan-center-index/recipes/ncurses/all/patches/0002-Optionally-include-sys-time.h.patch
conan-center-index/recipes/ncurses/all/patches/0008-Add-include-file-to-add-export-annotation.patch
conan-center-index/recipes/ncurses/all/patches/0017-msvc-fix-tests.patch
conan-center-index/recipes/ncurses/all/patches/0013-Fix-lib_gen.c.patch
conan-center-index/recipes/ncurses/all/patches/0007-No-import-export-declaration-on-class-members.patch
conan-center-index/recipes/ncurses/all/patches/0012-Learn-configure-about-msvc.patch
conan-center-index/recipes/ncurses/all/patches/0006-Add-potentially-missing-STDOUT_FILENO.patch
conan-center-index/recipes/ncurses/all/patches/0015-MSVC-access-does-not-support-X_OK.patch
conan-center-index/recipes/libharu/all/patches/0001-allow-cmake-subproject.patch
conan-center-index/recipes/libharu/all/patches/0002-linux-add-m-system-library.patch
conan-center-index/recipes/vorbis/all/patches/link-libm.patch
conan-center-index/recipes/physx/4.x.x/patches/0003-PsWindowsInlineAoS-msvc142-bug-workaround.patch
conan-center-index/recipes/physx/4.x.x/patches/0001-PsAllocator-include-typeinfo.patch
conan-center-index/recipes/physx/4.x.x/patches/0004-Conan-PhysXGpu-name-workaround.patch
conan-center-index/recipes/physx/4.x.x/patches/0002-GuGJKType-const-discard-qualifiers.patch
conan-center-index/recipes/physx/4.x.x/patches/0005-CMake-macos-ios-android-install-targets.patch
conan-center-index/recipes/libelfin/all/patches/commit-9d0db16d0a0b3c4f8aaa60a3e4dab295df34b6b2.patch
conan-center-index/recipes/libx265/all/patches/0001-remove_register_classifier.patch
conan-center-index/recipes/hdf4/all/patches/fix-export-macro.patch
conan-center-index/recipes/polylineencoder/all/patches/0001-cmake-target-name.patch
conan-center-index/recipes/polylineencoder/all/patches/0002-include-limits.patch
conan-center-index/recipes/polylineencoder/all/patches/0003-cmake-install.patch
conan-center-index/recipes/libmorton/all/patches/missing-includes.patch
conan-center-index/recipes/jsoncpp/all/patches/dont-force-pic-1.9.3.patch
conan-center-index/recipes/jsoncpp/all/patches/dont-force-pic-1.9.1.patch
conan-center-index/recipes/jsoncpp/all/patches/no-examples.patch
conan-center-index/recipes/jsoncpp/all/patches/dont-force-pic-1.9.2.patch
conan-center-index/recipes/clipper/all/patches/0001-include-install-directory.patch
conan-center-index/recipes/mpdecimal/2.5.x/patches/0001-2.5.0-msvc-fixes.patch
conan-center-index/recipes/mpdecimal/2.5.x/patches/0002-add-mingw-to-configure-ac.patch
conan-center-index/recipes/mpdecimal/2.4.2/patches/0001-msvc-fixes.patch
conan-center-index/recipes/mpdecimal/2.4.2/patches/0002-disable-vcstdint-h-vs2015.patch
conan-center-index/recipes/apriltag/all/patches/fix-cmake-3.1.2.patch
conan-center-index/recipes/apriltag/all/patches/fix-cmake-3.1.1.patch
conan-center-index/recipes/bliss/all/patches/0001-patch-sources.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-include-xerces-3.1.0.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/makefile-mitigate-long-line.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-include-xerces-3.1.2.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-nmake-opt-3.1.2.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-nmake-opt-3.1.0.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-autotools-3.1.0.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-include-jsonc.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-nmake-common.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-import-dll-msvc.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/ogrflatgeobuflayer-stdexcept.patch
conan-center-index/recipes/gdal/all/patches/3.1.x/fix-autotools-3.1.4.patch
conan-center-index/recipes/enkits/all/patches/cmake-install-lib-location.patch
conan-center-index/recipes/libgeotiff/all/patches/fix-cmake-1.6.0.patch
conan-center-index/recipes/libgeotiff/all/patches/fix-cmake-1.5.1.patch
conan-center-index/recipes/opus/all/patches/1.3.1-add-opus_buildtype-cmake.patch
conan-center-index/recipes/libuv/all/patches/1.34.2/fix-cmake.patch
conan-center-index/recipes/libuv/all/patches/1.38.0/fix-cmake.patch
conan-center-index/recipes/libuv/all/patches/1.38.1/fix-cmake.patch
conan-center-index/recipes/libuv/all/patches/1.40.0/fix-cmake.patch
conan-center-index/recipes/mpfr/all/patches/4.0.2-0001-windows-allow-mixed-shared-static.patch
conan-center-index/recipes/mpfr/all/patches/4.0.2-0002-windows-header-dll.patch
conan-center-index/recipes/mpfr/all/patches/4.1.0-0002-windows-header-dll.patch
conan-center-index/recipes/mpfr/all/patches/4.1.0-0001-windows-allow-mixed-shared-static.patch
conan-center-index/recipes/argon2/all/patches/0001-makefile-no-march.patch
conan-center-index/recipes/libsgp4/all/patches/fix-cmake-files.patch
conan-center-index/recipes/libbsd/all/patches/0001-support-macosx.patch
conan-center-index/recipes/libdisasm/all/patches/0001-fix-size-of-void.patch
conan-center-index/recipes/libdisasm/all/patches/0002-only-build-libdisasm-by-default.patch
conan-center-index/recipes/libdisasm/all/patches/0003-libdisasm-no-undefined.patch
conan-center-index/recipes/lemon/all/patches/0001-use-executable-template-path.patch
conan-center-index/recipes/hdf5/all/patches/conanize-link-szip-1.8.21.patch
conan-center-index/recipes/hdf5/all/patches/mingw-unused-ellipses.patch
conan-center-index/recipes/hdf5/all/patches/mingw-cmake-size-type-checks-1.10.5.patch
conan-center-index/recipes/hdf5/all/patches/conanize-link-szip-1.10.5+.patch
conan-center-index/recipes/hdf5/all/patches/build-either-static-or-shared-1.10.5.patch
conan-center-index/recipes/hdf5/all/patches/mingw-cmake-size-type-checks-1.8.21.patch
conan-center-index/recipes/hdf5/all/patches/mingw-fix-prefix-lib.patch
conan-center-index/recipes/hdf5/all/patches/build-either-static-or-shared-1.8.21.patch
conan-center-index/recipes/mariadb-connector-c/all/patches/0001-fix-install-and-static-or-shared.patch
conan-center-index/recipes/mariadb-connector-c/all/patches/0002-msvc-no-override-md-zi.patch
conan-center-index/recipes/mariadb-connector-c/all/patches/0003-include-order-windows-winsock2.patch
conan-center-index/recipes/clhep/all/patches/mingw-support.patch
conan-center-index/recipes/clhep/all/patches/fix-cmake.patch
conan-center-index/recipes/clhep/all/patches/msvc-2015-no-SFINAE.patch
conan-center-index/recipes/serf/all/patches/0002-1.3.9-scons-respect-flags.patch
conan-center-index/recipes/serf/all/patches/0003-1.3.9-scons-msvc.patch
conan-center-index/recipes/serf/all/patches/0001-1.3.9-scons-python3.patch
conan-center-index/recipes/nanodbc/all/patches/0001-odbc-from-cci.patch
conan-center-index/recipes/nanodbc/all/patches/0002-allow-windows-shared.patch
conan-center-index/recipes/cpr/all/patches/001-fix-curl-define.patch
conan-center-index/recipes/cpr/all/patches/001-1.5.2-curl-global-scope.patch
conan-center-index/recipes/cpr/all/patches/001-1.4.0-create-install.patch
conan-center-index/recipes/cpr/all/patches/002-1.4.0-zlib-use-target.patch
conan-center-index/recipes/cpr/all/patches/002-create-install.patch
conan-center-index/recipes/cpr/all/patches/004-curl-global-scope.patch
conan-center-index/recipes/cpr/all/patches/001-1.5.0-curl-global-scope.patch
conan-center-index/recipes/cpr/all/patches/002-1.5.0-not_search_for_openssl.patch
conan-center-index/recipes/cpr/all/patches/003-1.4.0-curl-global-scope.patch
conan-center-index/recipes/cpr/all/patches/003-zlib-use-target.patch
conan-center-index/recipes/h3/all/patches/fix-cmake-install-3.6.4.patch
conan-center-index/recipes/libaec/all/patches/0001-Fix-static-library-builds.patch
conan-center-index/recipes/celero/all/patches/lowercase-include-system-libs-windows.patch
conan-center-index/recipes/celero/all/patches/cmake-install-pic-cxx-standard-sytem-libs.patch
conan-center-index/recipes/celero/all/patches/typo-declspec.patch
conan-center-index/recipes/arrow/all/patches/2.0.0-0002-jemalloc.patch
conan-center-index/recipes/arrow/all/patches/2.0.0-0001-cmake.patch
conan-center-index/recipes/arrow/all/patches/2.0.0-0003-fix-shared-msvc.patch
conan-center-index/recipes/arrow/all/patches/1.0.0-0002-jemalloc.patch
conan-center-index/recipes/arrow/all/patches/1.0.0-0004-mallctl-takes-size_t.patch
conan-center-index/recipes/arrow/all/patches/1.0.0-0003-fix-shared-msvc.patch
conan-center-index/recipes/arrow/all/patches/1.0.0-0001-cmake.patch
conan-center-index/recipes/butteraugli/all/patches/0001-compilation-fixes-for-vs2015.patch
conan-center-index/recipes/boost/all/patches/boost_build_qcc_fix_debug_build_parameter_since_1_74.patch
conan-center-index/recipes/boost/all/patches/boost_core_qnx_cxx_provide___cxa_get_globals.patch
conan-center-index/recipes/boost/all/patches/boost_build_asmflags.patch
conan-center-index/recipes/boost/all/patches/boost_log_filesystem_no_deprecated_1_72.patch
conan-center-index/recipes/boost/all/patches/boost_build_qcc_fix_debug_build_parameter.patch
conan-center-index/recipes/boost/all/patches/0001-revert-cease-dependence-on-range.patch
conan-center-index/recipes/boost/all/patches/static_object_init.patch
conan-center-index/recipes/boost/all/patches/python_base_prefix_since_1_74.patch
conan-center-index/recipes/boost/all/patches/solaris_pthread_data.patch
conan-center-index/recipes/boost/all/patches/bcp_namespace_issues_1_71.patch
conan-center-index/recipes/boost/all/patches/python_base_prefix.patch
conan-center-index/recipes/boost/all/patches/0001-beast-fix-moved-from-executor.patch
conan-center-index/recipes/boost/all/patches/bcp_namespace_issues_1_72.patch
conan-center-index/recipes/boost/all/patches/bcp_namespace_issues_1_70.patch
conan-center-index/recipes/boost/all/patches/support_msvc_2019.patch
conan-center-index/recipes/kangaru/all/patches/fix-cmake.patch
conan-center-index/recipes/libcorrect/all/patches/0001-Support-CMake-BUILD_SHARED_LIBS.patch
conan-center-index/recipes/libcorrect/all/patches/0002-Export-symbols-for-windows.patch
conan-center-index/recipes/fmt/all/patches/fix-install-6.0.0.patch
conan-center-index/recipes/fmt/all/patches/fix-install-5.3.0.patch
conan-center-index/recipes/fmt/all/patches/fix-mingw-msvc2015-export-assert-fail-6.1.0.patch
conan-center-index/recipes/libmediainfo/all/patches/0001-cmakelists-CMAKE_MODULE_PATH-find_package.patch
conan-center-index/recipes/libmediainfo/all/patches/0003-install-no-pdbs.patch
conan-center-index/recipes/libmediainfo/all/patches/0002-no-debug-postfix.patch
conan-center-index/recipes/libftdi/0.x/patches/0001-cmake-fixes.patch
conan-center-index/recipes/elfutils/all/patches/0002-add-enable-static-option-to-configure.patch
conan-center-index/recipes/elfutils/all/patches/0001-Add-enable-werror-configure-option.patch
conan-center-index/recipes/zimg/all/patches/0004-msvc-remove-toolset-2.9.3.patch
conan-center-index/recipes/zimg/all/patches/0003-include-stddef.patch
conan-center-index/recipes/zimg/all/patches/0005-msvc-remove-toolset-3.0.1.patch
conan-center-index/recipes/zimg/all/patches/0001-msvc-remove-toolset-common.patch
conan-center-index/recipes/zimg/all/patches/0002-msvc-solution.patch
conan-center-index/recipes/apr-util/all/patches/0001-cmake-build-only-shared-static.patch
conan-center-index/recipes/apr-util/all/patches/0003-disable-check-APR_LIBRARIES.patch
conan-center-index/recipes/apr-util/all/patches/0002-apu-config-prefix-env.patch
conan-center-index/recipes/brotli/all/patches/0001-target-props.patch
conan-center-index/recipes/brotli/all/patches/0002-target-props.patch
conan-center-index/recipes/systemc/all/patches/CMakeLists.patch
conan-center-index/recipes/systemc/all/patches/sc_string_view.patch
conan-center-index/recipes/spirv-tools/all/patches/support-SPV_KHR_fragment_shading_rate.patch
conan-center-index/recipes/aws-c-event-stream/all/patches/0002-use-PROJECT_SOURCE_DIR.patch
conan-center-index/recipes/aws-c-event-stream/all/patches/0001-disable-tests-bin.patch
conan-center-index/recipes/matio/all/patches/require-cmake-3.10.patch
conan-center-index/recipes/matio/all/patches/disable-hdf5-target.patch
conan-center-index/recipes/matio/all/patches/patch-apple-no-undefined.patch
conan-center-index/recipes/libuvc/all/patches/0001-adjust-libusb.patch
conan-center-index/recipes/libuvc/all/patches/0002-adjust-install-folder.patch
conan-center-index/recipes/charls/all/patches/enum-name-lookup-for-gcc5.patch
conan-center-index/recipes/charls/all/patches/constexpr-msvc2015.patch
conan-center-index/recipes/charls/all/patches/fix-missing-includes-for-clang5-stdc++.patch
conan-center-index/recipes/charls/all/patches/def-and-rc-for-msvc-only.patch
conan-center-index/recipes/zeromq/all/patches/0002-problem-invalid-syntax-for-calling-convention-on-function.patch
conan-center-index/recipes/zeromq/all/patches/0001-problem-__try-and-__except-isn-t-universally-supported-on-windows.patch
conan-center-index/recipes/quirc/all/patches/replace-vla.patch
conan-center-index/recipes/quirc/all/patches/remove-c99-features.patch
conan-center-index/recipes/harfbuzz/all/patches/source_subfolder.patch
conan-center-index/recipes/date/all/patches/0001-fix-uwp.patch
conan-center-index/recipes/date/all/patches/cmake.patch
conan-center-index/recipes/date/all/patches/cmake-3.0.0.patch
conan-center-index/recipes/date/all/patches/string_view.patch
conan-center-index/recipes/cppcommon/all/patches/00001-update-cmakelists.patch
conan-center-index/recipes/cppcommon/all/patches/00002-fix-cross-platform-issues.patch
conan-center-index/recipes/jerryscript/all/patches/001-2.5.0-remove-werror.patch
conan-center-index/recipes/base64/all/patches/cmake.patch
conan-center-index/recipes/base64/all/patches/make.patch
conan-center-index/recipes/cryptopp/all/patches/fix-cmake.patch
conan-center-index/recipes/getdns/all/patches/1.6.0-0002-fix-exports-extension-libraries.patch
conan-center-index/recipes/getdns/all/patches/1.6.0-0001-install-runtimes.patch
conan-center-index/recipes/getdns/all/patches/1.6.0-0003-let-find-modules-use-pkgconfig.patch
conan-center-index/recipes/getdns/all/patches/1.6.0-0004-dont-install-symlinked-license.patch
conan-center-index/recipes/tcp-wrappers/all/patches/0002-fix-warnings-by-include-headers.patch
conan-center-index/recipes/tcp-wrappers/all/patches/0003-add-severity-level-to-library.patch
conan-center-index/recipes/tcp-wrappers/all/patches/0001-shared-clang.patch
conan-center-index/recipes/glog/all/patches/fix-cmake.patch
conan-center-index/recipes/lerc/all/patches/add-CMakeLists-and-static.patch
conan-center-index/recipes/xapian-core/all/patches/0001-add-msvc-cl-sh.patch
conan-center-index/recipes/tinyspline/all/patches/0.3.0-0001-fix-cmake.patch
conan-center-index/recipes/tinyspline/all/patches/0.2.0-0001-fix-cmake.patch
conan-center-index/recipes/hiredis/all/patches/fix-cmake.patch
conan-center-index/recipes/sundials/all/patches/0001-disable-in-source-fail.patch
conan-center-index/recipes/minizip/1.2.11/minizip.patch
conan-center-index/recipes/stx/all/patches/0002-cmake_module_path.patch
conan-center-index/recipes/stx/all/patches/0001-abseil_find_package.patch
conan-center-index/recipes/cspice/all/patches/patches20171106.patch
conan-center-index/recipes/cspice/all/patches/isatty.patch
conan-center-index/recipes/crow/all/patches/001-fix-cmake-errors.patch
conan-center-index/recipes/mbedtls/all/patches/0001-visual-studio-shared-gpl.patch
conan-center-index/recipes/mbedtls/all/patches/0001-visual-studio-shared-apache.patch
conan-center-index/recipes/libde265/all/patches/optional-sdl.patch
conan-center-index/recipes/lz4/all/patches/0002-cmake-optional-cli.patch
conan-center-index/recipes/lz4/all/patches/0001-cmake-add-shared-DEFINE_SYMBOL.patch
conan-center-index/recipes/jbig/all/patches/0002-fix-msvc-export.patch
conan-center-index/recipes/jbig/all/patches/0001-add-missing-export.patch
conan-center-index/recipes/aws-c-common/all/patches/0001-disable-fPIC.patch
conan-center-index/recipes/openal/all/patches/1.19.1/gcc-10-fnocommon.patch
conan-center-index/recipes/coin-cgl/all/patches/0001-no-pkg-config-check.patch
conan-center-index/recipes/srt/all/patches/001-cmake-link-targets.patch
conan-center-index/recipes/srt/all/patches/002-cmake-link-targets.patch
conan-center-index/recipes/libcurl/all/patches/002-add-missing-file-FindZstd.patch
conan-center-index/recipes/libcurl/all/patches/001-Update-FindLibSSH2.cmake-add-libssh2-as-possible-nam.patch
conan-center-index/recipes/twitchtv-libsoundtrackutil/all/patches/clang-8-fix.patch
conan-center-index/recipes/flatc/all/patches/0001-buildflatbuffers-cmake.patch
conan-center-index/recipes/libcpuid/all/patches/0.5.0-cmake-fixes.patch
conan-center-index/recipes/svgwrite/all/patches/0001-remove-gcc-flags.patch
conan-center-index/recipes/svgwrite/all/patches/0002-span-lite-ns.patch
conan-center-index/recipes/cairo/all/patches/0001-msvc-update-build-scripts-to-compile-with-more-featu.patch
conan-center-index/recipes/miniz/all/patches/2.1.0/001-remove-examples.patch
conan-center-index/recipes/mysql-connector-c/all/patches/001-20028_all_mysql-5.6-gcc7.patch
conan-center-index/recipes/mysql-connector-c/all/patches/003-cmake-install-standard-locations.patch
conan-center-index/recipes/mysql-connector-c/all/patches/002-mysql_config.patch
conan-center-index/recipes/fribidi/all/patches/0001-meson-no-tests-bin.patch
conan-center-index/recipes/eigen/all/patches/0001-assert-exception-upstream-issue-2011.patch
conan-center-index/recipes/zlib/1.2.11/patches/0001-minizip.patch
conan-center-index/recipes/zlib/1.2.11/patches/0002-gzguts-xcode12-compile-fix.patch
conan-center-index/recipes/zlib/1.2.11/patches/0003-cmake-fix-msys2-subsystem.patch
conan-center-index/recipes/glslang/all/patches/conanize-cmake-8.13.3559.patch
conan-center-index/recipes/ois/all/patches/1.5/001_export_headers_from_CMAKE_CURRENT_SOURCE_DIR.patch
conan-center-index/recipes/hdrhistogram-c/all/patches/cmake-install.patch
conan-center-index/recipes/libnghttp2/all/patches/fix-addNghttp2IncludesPathCMake.patch
conan-center-index/recipes/libnghttp2/all/patches/nghttp_static_include_directories_1.42.0.patch
conan-center-index/recipes/libnghttp2/all/patches/nghttp_static_include_directories.patch
conan-center-index/recipes/lua/all/patches/5.3.5/lua_mobile.patch
conan-center-index/recipes/libusb-compat/all/patches/0002-fix-msvc-linkage-and-fix-msvc-vararg-macros.patch
conan-center-index/recipes/libusb-compat/all/patches/0001-fix-autoconf-msvc-mingw.patch
conan-center-index/recipes/ragel/6.x/patches/0001-unistd.patch
conan-center-index/recipes/ninja/1.10.x/patches/build_testing_option.patch
conan-center-index/recipes/ninja/1.10.x/patches/build_testing_option_1.10.1.patch
conan-center-index/recipes/ninja/1.10.x/patches/add_install_target_to_cmake_build.patch
conan-center-index/recipes/ninja/1.10.x/patches/add_subproject_support.patch
conan-center-index/recipes/cunit/all/patches/0001-configure-in-msvc-shortcuts.patch
conan-center-index/recipes/kcov/all/patches/0001-fix-SOLIB-path.patch
conan-center-index/recipes/kcov/all/patches/0002-fix-missing-libssl-dependency.patch
conan-center-index/recipes/openexr/2.3.0/patches/IlmImf__ImfSystemSpecific.cpp.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0004-fix-cmake-install.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0003-fix-cmake-install.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0005_SSL_CTX_set_alpn_protos-for-1-3-7.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0002-fix-MinGW-and-OSX-builds-for-1-3-1.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0005-fix-cmake-install-for-1-3-7.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0001-fix-MinGW-and-OSX-builds-for-1-3-0.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0002-fix-MinGW-and-OSX-builds-for-1-3-5.patch
conan-center-index/recipes/paho-mqtt-c/all/patches/0002-fix-MinGW-and-OSX-builds-for-1-3-4.patch
conan-center-index/recipes/draco/all/patches/non-copy-ellision-workaround.patch
conan-center-index/recipes/getopt-for-visual-studio/all/patches/0001-allow-usage-in-multiple-compilation-units.patch
conan-center-index/recipes/open62541/all/patches/1_1_3.patch
conan-center-index/recipes/open62541/all/patches/1_0_3.patch
conan-center-index/recipes/libmodbus/all/patches/0001-msvc-fixes.patch
conan-center-index/recipes/giflib/5.2.x/patches/0001-msvc-unistd.patch
conan-center-index/recipes/libwebp/all/patches/0001-fix-dll-export.patch
conan-center-index/recipes/quickfix/all/patches/0004-remove-tests-from-compilatin-unit-performance-and-ac.patch
conan-center-index/recipes/quickfix/all/patches/0008-manage-mysql-through-conan.patch
conan-center-index/recipes/quickfix/all/patches/0006-manage-postgres-through-conan.patch
conan-center-index/recipes/quickfix/all/patches/0007-add-support-to-static-libraries-for-non-windows-buil.patch
conan-center-index/recipes/quickfix/all/patches/0003-fix-condition-for-using-tr1-namespace.patch
conan-center-index/recipes/quickfix/all/patches/0001-Fix-build-for-C-17-replace-throw-.-with-EXCEPT.patch
conan-center-index/recipes/quickfix/all/patches/0002-except-copy.patch
conan-center-index/recipes/quickfix/all/patches/0005-inc.-required-CMake-version-add-conan-basic-setup-an.patch
conan-center-index/recipes/dcmtk/all/patches/0001-cmake-use-conan-packages.patch
conan-center-index/recipes/tcl/8.6.10/patches/no-read-only-data.patch
conan-center-index/recipes/openimageio/all/patches/2.2.7.0-cmake-targets.patch
conan-center-index/recipes/pkgconf/all/patches/0001-meson-use-declare-dependencies.patch
conan-center-index/recipes/pkgconf/all/patches/0002-c89-compatible.patch
conan-center-index/recipes/mongo-cxx-driver/all/patches/diff.patch
conan-center-index/recipes/re2c/all/patches/0001-add-msvc_cl-sh.patch
conan-center-index/recipes/re2c/all/patches/2.0.3-0001-add-missing-include.patch
conan-center-index/recipes/crunch/all/patches/001_linux64_compilation_fixes.patch
conan-center-index/recipes/crunch/all/patches/003_fix_missing_cast.patch
conan-center-index/recipes/crunch/all/patches/002_fix_clang_inline.patch
conan-center-index/recipes/openmesh/all/patches/cmake-install.patch
conan-center-index/recipes/coin-clp/all/patches/0001-no-pkg-config-check.patch
conan-center-index/recipes/poppler-data/all/patches/0001-cmake-use-GNUInstallDirs.patch
conan-center-index/recipes/gtest/all/patches/gtest-1.10.0.patch
conan-center-index/recipes/gtest/all/patches/gtest-1.10.0-override.patch
conan-center-index/recipes/gtest/all/patches/gtest-1.8.1.patch
conan-center-index/recipes/zxing-cpp/all/patches/0001-Fix-C2327-for-MSVC-2015.patch
conan-center-index/recipes/mongo-c-driver/all/patches/disable-shared-when-static.patch
conan-center-index/recipes/flac/all/patches/fix-cmake.patch
conan-center-index/recipes/kealib/all/patches/fix-export-symbols-and-cmake.patch
conan-center-index/recipes/kealib/all/patches/fix-cmake-1.4.14.patch
conan-center-index/recipes/pfr/all/patches/50_add_license.patch
conan-center-index/recipes/sqlcipher/all/patches/fix_configure-v4.4.0.patch
conan-center-index/recipes/sqlcipher/all/patches/Makefile.msc-v4.4.0.patch
conan-center-index/recipes/sqlcipher/all/patches/Makefile.in-v4.4.0.patch
conan-center-index/recipes/sqlcipher/all/patches/Makefile.msc-v4.3.0.patch
conan-center-index/recipes/sqlcipher/all/patches/fix_configure-v4.3.0.patch
conan-center-index/recipes/sqlcipher/all/patches/Makefile.in-v4.3.0.patch
conan-center-index/recipes/odbc/all/patches/missing-declarations.patch
conan-center-index/recipes/gettext/all/patches/0003-Reported-by-Gabor-Z.-Papp-gzp-papp.hu.patch
conan-center-index/recipes/gettext/all/patches/0001-build-Fix-build-errors-with-MSVC.patch
conan-center-index/recipes/gettext/all/patches/0002-memmove-is-intrinsic-function-on-MSVC.patch
conan-center-index/recipes/mpc/all/patches/1.2.0-0001-asin-missing-limits.patch
conan-center-index/recipes/libssh2/all/patches/0002-pthread.patch
conan-center-index/recipes/libssh2/all/patches/0001-pthread.patch
conan-center-index/recipes/make/all/patches/0001-clang.patch
conan-center-index/recipes/cpp-jwt/all/patches/001-fix-msvc-14-compilation.patch
conan-center-index/recipes/termcap/all/patches/0002-macOS.patch
conan-center-index/recipes/termcap/all/patches/0001-msvc.patch
conan-center-index/recipes/cose-c/all/patches/001-fix-cmake-targets.patch
conan-center-index/recipes/libcbor/all/patches/0.7.0/001_fix_shared_build.patch
conan-center-index/recipes/zstd/all/patches/0001-cmake-install-dll.patch
conan-center-index/recipes/coin-utils/all/patches/0001-no-check-pkgconfig.patch
conan-center-index/recipes/jinja2cpp/all/patches/fix-cmake.patch
conan-center-index/recipes/systemc-cci/1.0.0/patches/makefile.patch
conan-center-index/recipes/systemc-cci/1.0.0/patches/broker.patch
conan-center-index/recipes/systemc-cci/1.0.0/patches/cci_param_untyped_handle.patch
conan-center-index/recipes/systemc-cci/1.0.0/patches/cci_value_converter.patch
conan-center-index/recipes/systemc-cci/1.0.0/patches/rapidjson.patch
conan-center-index/recipes/libsodium/1.0.18/patches/msvc_props.patch
conan-center-index/recipes/c-blosc/all/patches/cmake-dependencies-1.19.0.patch
conan-center-index/recipes/c-blosc/all/patches/cmake-dependencies-1.20.0+.patch
conan-center-index/recipes/c-blosc/all/patches/cmake-dependencies-1.18.1-.patch
conan-center-index/recipes/libdwarf/all/patches/0001-patch.patch
conan-center-index/recipes/sqlpp11-connector-sqlite3/all/patches/cmake-dependencies.patch
conan-center-index/recipes/cfitsio/all/patches/fix-cmake-3.490.patch
conan-center-index/recipes/cfitsio/all/patches/windows-use-strtok_s.patch
conan-center-index/recipes/cfitsio/all/patches/fix-cmake-3.470.patch
conan-center-index/recipes/glad/all/patches/0002-CMake-handle-all-specs.patch
conan-center-index/recipes/glad/all/patches/0001-CMake-handle-all-specs.patch
conan-center-index/recipes/apr/all/patches/0001-cmake-build-only-shared-static.patch
conan-center-index/recipes/apr/all/patches/0003-cmake-gen_test_char-use-target.patch
conan-center-index/recipes/apr/all/patches/0002-apr-config-prefix-env.patch
conan-center-index/recipes/twitch-native-ipc/all/patches/cmake-fixes.patch
conan-center-index/recipes/twitch-native-ipc/all/patches/linux-build-fixes.patch
conan-center-index/recipes/twitch-native-ipc/all/patches/export-fixes.patch
conan-center-index/recipes/autoconf/all/patches/0001-autom4te-relocatable.patch
conan-center-index/recipes/autoconf/all/patches/0002-no-perl-path-in-shebang.patch
conan-center-index/recipes/autoconf/all/patches/0004-no-embedded-m4-paths.patch
conan-center-index/recipes/autoconf/all/patches/0003-uppercase-autom4te_perllibdir.patch
conan-center-index/recipes/sqlitecpp/all/patches/2.4.0/0001-mingw.patch
conan-center-index/recipes/sqlitecpp/all/patches/3.1.1/0001-conan.patch
conan-center-index/recipes/sqlitecpp/all/patches/2.5.0/0001-conan.patch
conan-center-index/recipes/fcl/all/patches/fix-mingw-bigobj.patch
conan-center-index/recipes/fcl/all/patches/conanize-cmake-0.6.1.patch
conan-center-index/recipes/fcl/all/patches/fix-alias-type-msvc2015.patch
conan-center-index/recipes/m4/all/patches/0007-vasnprintf-port-to-macos-10.13.patch
conan-center-index/recipes/m4/all/patches/0006-manywarnings-update-for-gcc-7.patch
conan-center-index/recipes/m4/all/patches/0008-open-files-in-binary-mode.patch
conan-center-index/recipes/m4/all/patches/0004-fix-checks.patch
conan-center-index/recipes/m4/all/patches/0009-disable-hardening-in-source.patch
conan-center-index/recipes/m4/all/patches/0003-secure_snprintf.patch
conan-center-index/recipes/m4/all/patches/0001-fflush-adjust-to-glibc-2.28-libio.h-removal.patch
conan-center-index/recipes/m4/all/patches/0002-fflush-be-more-paranoid-about-libio.h-change.patch
conan-center-index/recipes/m4/all/patches/0005-vasnprintf-Fix-for-MSVC-14.patch
conan-center-index/recipes/cpprestsdk/all/patches/0003-find-cmake-targets.patch
conan-center-index/recipes/cpprestsdk/all/patches/0001-find-cmake-targets.patch
conan-center-index/recipes/cpprestsdk/all/patches/0002-remove-wconversion.patch
conan-center-index/recipes/libmysqlclient/all/patches/0004-find-openssl-debug.patch
conan-center-index/recipes/libmysqlclient/all/patches/0002-dont-install-static-libraries+fix-mysql-config.patch
conan-center-index/recipes/libmysqlclient/all/patches/0001-find-cmake.patch
conan-center-index/recipes/libmysqlclient/all/patches/0003-msvc-install-no-pdb.patch
conan-center-index/recipes/libtasn1/all/patches/0001-do-not-add-static-to-functions-meant-to-be-built.patch
conan-center-index/recipes/wslay/all/patches/0001-msvc-support.patch
conan-center-index/recipes/wslay/all/patches/0002-cmake-install-shared-artifacts.patch
conan-center-index/recipes/freexl/all/patches/fix-nmake-1.0.5.patch
conan-center-index/recipes/freexl/all/patches/fix-nmake-1.0.6.patch
conan-center-index/recipes/freexl/all/patches/msvc-round-lround.patch
conan-center-index/recipes/glew/all/patches/vs16-release-fix.patch
conan-center-index/recipes/libmp3lame/all/6410.patch
conan-center-index/recipes/libmp3lame/all/6416.patch
conan-center-index/recipes/libmp3lame/all/android.patch
conan-center-index/recipes/cc65/all/patches/2.19-0001-no-embedded-paths-makefile.patch
conan-center-index/recipes/cc65/all/patches/2.18-0001-no-embedded-paths-makefile.patch
conan-center-index/recipes/cc65/all/patches/2.18-0002-libsrc-use-extension.patch
conan-center-index/recipes/cc65/all/patches/2.19-0002-libsrc-use-extension.patch
conan-center-index/recipes/paho-mqtt-cpp/all/patches/1.1/0002-ios_fix.patch
conan-center-index/recipes/paho-mqtt-cpp/all/patches/1.1/0001-deadlock_and_remlog-for-1-1.patch
conan-center-index/recipes/paho-mqtt-cpp/all/patches/1.0.1/0001-fix-cmake-module-path.patch
conan-center-index/recipes/paho-mqtt-cpp/all/patches/1.0.1/0003-fix-paho-mqtt-cpp-config-cmake.patch
conan-center-index/recipes/paho-mqtt-cpp/all/patches/1.0.1/0002-fix-cmake-find-paho-mqtt-c-static.patch
conan-center-index/recipes/jwt-cpp/all/patches/0002-fix-openssl-change-version.patch
conan-center-index/recipes/jwt-cpp/all/patches/0003-fix-picojson-header-location-for-conan.patch
conan-center-index/recipes/libevent/all/patches/fix-cmake-2.1.11.patch
conan-center-index/recipes/libevent/all/patches/fix-cmake-2.1.12.patch
conan-center-index/recipes/libkml/all/patches/fix-for-mingw-and-empty-literal-for-vc.patch
conan-center-index/recipes/libkml/all/patches/export-extern-symbols-for-msvc.patch
conan-center-index/recipes/libkml/all/patches/conanize-cmakelists.patch
conan-center-index/recipes/flatbuffers/all/patches/0001-buildflatbuffers-cmake.patch
conan-center-index/recipes/libyuv/all/patches/001-cmake.patch
conan-center-index/recipes/tgbot/all/patches/001-build-system.patch
conan-center-index/recipes/libqrencode/all/patches/0001-remove-deprecated-attribute.patch
conan-center-index/recipes/libqrencode/all/patches/0002-cmake-fix-install.patch
conan-center-index/recipes/libqrencode/all/patches/0003-cmake-fix-install-4.1.1.patch
conan-center-index/recipes/coin-osi/all/patches/0001-no-pkg-config-check.patch
conan-center-index/recipes/doxygen/all/patches/1.8.18-0001-relocatable-cmake.patch
conan-center-index/recipes/doxygen/all/patches/1.8.17-0001-relocatable-cmake.patch
conan-center-index/recipes/doxygen/all/patches/1.8.20-0001-relocatable-cmake.patch
conan-center-index/recipes/ignition-cmake/all/patches/0001-cmake-fixes.patch
conan-center-index/recipes/libsquish/all/patches/fix-cmake-simd-openmp-install.patch
conan-center-index/recipes/libsquish/all/patches/export-symbols.patch
conan-center-index/recipes/mozjpeg/all/patches/4.0.0-0001-cmake-fixes.patch
conan-center-index/recipes/mozjpeg/all/patches/3.3.1-0001-cmake-fixes.patch
conan-center-index/recipes/openh264/all/patches/1.7.0-0003-mingw-override-CC-CXX-AR-from-env.patch
conan-center-index/recipes/openh264/all/patches/2.1.1-0002-no-fpic.patch
conan-center-index/recipes/openh264/all/patches/1.7.0-0002-no-fpic.patch
conan-center-index/recipes/openh264/all/patches/1.7.0-0001-platform-android.mk.patch
conan-center-index/recipes/openh264/all/patches/2.1.1-0001-platform-android.mk.patch
conan-center-index/recipes/ezc3d/all/patches/fix-export-symbols.patch
conan-center-index/recipes/premake/5.x/patches/0001-5.0.0-alpha14-mingw.patch
conan-center-index/recipes/premake/5.x/patches/0001-5.0.0-alpha15-mingw.patch
conan-center-index/recipes/glfw/all/patches/fix-objc-cmake3.19+.patch
conan-center-index/recipes/libcds/all/patches/fix-cmake.patch
conan-center-index/recipes/aws-checksums/all/patches/0002-disable-overriding-fPIC.patch
conan-center-index/recipes/aws-checksums/all/patches/0003-disable-building-tests.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.5.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.4-b7ffd640ec48ada93045f8c46fc65f823490819b.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.4.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.4-7539d53b54f08f056dc9366c8d5c24c5d749cfce.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.5-74dd7d6733d1ab6b79994f4acbc1ad86ba950d23.patch
conan-center-index/recipes/backward-cpp/all/patches/backward-cpp-1.5-add-iterator-include.patch
conan-center-index/recipes/libzen/all/patches/0002-export-data-in-windows-dlls.patch
conan-center-index/recipes/libzen/all/patches/0001-enable-WIN32-shared-libraries.patch
conan-center-index/recipes/valijson/all/patches/nlohmann_json.patch
conan-center-index/recipes/rabbitmq-c/all/patches/0001-Change-openssl-variable-names.patch
conan-center-index/recipes/opusfile/all/patches/001-disable-cert-store-integration.patch
conan-center-index/recipes/uriparser/all/patches/fix-lib-name-mingw-0.9.4.patch
conan-center-index/recipes/uriparser/all/patches/fix-lib-name-mingw-0.9.3.patch
conan-center-index/recipes/libtorrent/all/patches/1.2.3-0004-increase-handle-storage-sizes.patch
conan-center-index/recipes/libtorrent/all/patches/1.2.3-0002-boost-system-header-only-1.69+.patch
conan-center-index/recipes/libtorrent/all/patches/1.2.3-0003-include-cstddef.patch
conan-center-index/recipes/libtorrent/all/patches/1.2.3-0001-cmake-fix-conan-boost-openssl.patch
conan-center-index/recipes/libtorrent/all/patches/2.0.1-0001-cmake-fix-conan-boost-openssl.patch
conan-center-index/recipes/itk/all/patches/0002-gdcm-dependencies.patch
conan-center-index/recipes/itk/all/patches/0001-find-conan-packages.patch
conan-center-index/recipes/librdkafka/all/patches/0002-Change-library-targets-and-result-variables-1-3-0.patch
conan-center-index/recipes/librdkafka/all/patches/0003-Fix-broken-version-1-4-0-on-windows.patch
conan-center-index/recipes/librdkafka/all/patches/0002-Change-library-targets-and-result-variables-1-4-0.patch
conan-center-index/recipes/librdkafka/all/patches/0001-Remove-cmake-module-path-and-change-library-names.patch
conan-center-index/recipes/fftw/all/patches/fix-cmake.patch
conan-center-index/recipes/openssl/1.x.x/patches/1.1.1-tvos.patch
conan-center-index/recipes/llvm-openmp/all/patches/0001-disable-build-testing.patch
conan-center-index/recipes/llvm-openmp/all/patches/0001-disable-build-testing_10.0.0.patch
conan-center-index/recipes/univalue/all/patches/0001-fix-windows.patch
conan-center-index/recipes/libspatialindex/all/patches/fix-static-and-mingw.patch
conan-center-index/recipes/libspatialindex/all/patches/fix-capi.patch
conan-center-index/recipes/rttr/all/patches/002_fix_license_installer.patch
conan-center-index/recipes/rttr/all/patches/001_fix_build_without_RTTI.patch
conan-center-index/recipes/libxlsxwriter/all/patches/001-patch-cmake-conan-targets.patch
conan-center-index/recipes/kcp/all/patches/0001-kcp-remove-add_library-STATIC.patch
conan-center-index/recipes/irrxml/all/patches/1.2/irrtypes_debug_vs.patch
conan-center-index/recipes/ftjam/all/patches/0001-jam-2.5-overflow.patch
conan-center-index/recipes/ftjam/all/patches/0002-msvc-mingw-fix-makefile.patch
conan-center-index/recipes/cassandra-cpp-driver/all/patches/2.15.3/fix-rapidjson.patch
conan-center-index/recipes/cassandra-cpp-driver/all/patches/2.15.3/fix-cmake.patch
conan-center-index/recipes/verilator/all/patches/0001-split-opt-and-debug-build-install.patch
conan-center-index/recipes/verilator/all/patches/0002-msvc-patches.patch
conan-center-index/recipes/verilator/all/patches/0003-add-msvc_link-sh.patch
conan-center-index/recipes/guetzli/all/patches/0001-no-debug.patch
conan-center-index/recipes/szip/all/patches/fix_unknown_size_t.patch
conan-center-index/recipes/szip/all/patches/build_either_static_or_shared.patch
conan-center-index/recipes/argtable2/all/patches/2.13-0002-msvc-nmake-accept-conan-flags.patch
conan-center-index/recipes/argtable2/all/patches/2.13-0001-enable-mingw-dll.patch
conan-center-index/recipes/squirrel/all/patches/fix-cmake-static-shared.patch
conan-center-index/recipes/zziplib/all/patches/001_fix.patch
conan-center-index/recipes/lief/all/patches/001_link_to_conan.patch
conan-center-index/recipes/lief/all/patches/003_fix_json_include_path.patch
conan-center-index/recipes/lief/all/patches/004_fix_elf_parser.patch
conan-center-index/recipes/lief/all/patches/002_fix_resources_manager.patch
conan-center-index/recipes/lief/all/patches/005_fix_compiler_detection.patch
conan-center-index/recipes/lief/all/patches/006_fix_binary_cpp.patch
conan-center-index/recipes/folly/all/patches/0003-boost-shared-ptr.patch
conan-center-index/recipes/folly/all/patches/0008-find-packages.patch
conan-center-index/recipes/folly/all/patches/0009-ill-formed-atomic-copy.patch
conan-center-index/recipes/folly/all/patches/0013-include-bit.patch
conan-center-index/recipes/folly/all/patches/0012-compiler-flags.patch
conan-center-index/recipes/folly/all/patches/0001-find-packages.patch
conan-center-index/recipes/folly/all/patches/0005-include-atomic.patch
conan-center-index/recipes/folly/all/patches/0004-disable-posix-names.patch
conan-center-index/recipes/folly/all/patches/0007-allow-builtins.patch
conan-center-index/recipes/folly/all/patches/0006-duplicate-hash.patch
conan-center-index/recipes/folly/all/patches/0015-benchmark-format-macros.patch
conan-center-index/recipes/folly/all/patches/0011-disable-logger-example.patch
conan-center-index/recipes/folly/all/patches/0002-compiler-flags.patch
conan-center-index/recipes/folly/all/patches/0010-duplicate-hash.patch
conan-center-index/recipes/folly/all/patches/0014-find-librt.patch
conan-center-index/recipes/libsndfile/all/patches/0001-disable-static-runtime-logic.patch
conan-center-index/recipes/eastl/all/patches/3.17.03-0002-revert-c++14-constexpr.patch
conan-center-index/recipes/eastl/all/patches/3.15.00-0001-cmake-shared-use-conan-add-install.patch
conan-center-index/recipes/eastl/all/patches/3.17.03-0001-cmake-shared-use-conan-add-install.patch
conan-center-index/recipes/docopt.cpp/all/patches/cmake-library-0.6.2.patch
conan-center-index/recipes/docopt.cpp/all/patches/msvc-dll-export-0.6.3.patch
conan-center-index/recipes/docopt.cpp/all/patches/include-stdexcept.patch
conan-center-index/recipes/docopt.cpp/all/patches/cmake-library-0.6.3.patch
conan-center-index/recipes/docopt.cpp/all/patches/msvc-dll-export-0.6.2.patch
conan-center-index/recipes/jasper/all/patches/fix-exported-symbols.patch
conan-center-index/recipes/bison/all/patches/0003-3.5.3-msvc-changes.patch
conan-center-index/recipes/bison/all/patches/0001-create_pipe-uses-O_TEXT-not-O_BINARY-mode.patch
conan-center-index/recipes/bison/all/patches/0005-gnulib-limit-search-range-of-_setmaxstdio.patch
conan-center-index/recipes/bison/all/patches/0004-3.5.3-relocatable.patch
conan-center-index/recipes/bison/all/patches/0002-3.7.1-open-source-file-in-binary-mode-MS-ftell-bug-ks-68337.patch
conan-center-index/recipes/bison/all/patches/0002-3.5.3-open-source-file-in-binary-mode-MS-ftell-bug-ks-68337.patch
conan-center-index/recipes/protobuf/all/patches/upstream-issue-7567-no-export-template-define.patch
conan-center-index/recipes/protobuf/all/patches/upstream-pr-7761-cmake-regex-fix.patch
conan-center-index/recipes/argtable3/all/patches/3.1.5-0001-cmake-fixes.patch
conan-center-index/recipes/libsigcpp/3.x.x/patches/0001-libsigcpp.patch
conan-center-index/recipes/automake/all/patches/0002-no-perl-path-in-shebang-0.16.3.patch
conan-center-index/recipes/automake/all/patches/0002-no-perl-path-in-shebang-0.16.1.patch
conan-center-index/recipes/automake/all/patches/0003-remove-embedded-datadirs-introduce-automake-conan-includes-0.16.2.patch
conan-center-index/recipes/automake/all/patches/0001-help2man-no-discard-stderr-0.16.3.patch
conan-center-index/recipes/automake/all/patches/0001-help2man-no-discard-stderr-0.16.1.patch
conan-center-index/recipes/automake/all/patches/0004-introduce-automake_perllibdir-0.16.2.patch
conan-center-index/recipes/automake/all/patches/0002-no-perl-path-in-shebang-0.16.2.patch
conan-center-index/recipes/automake/all/patches/0003-remove-embedded-datadirs-introduce-automake-conan-includes-0.16.1.patch
conan-center-index/recipes/automake/all/patches/0004-introduce-automake_perllibdir-0.16.3.patch
conan-center-index/recipes/automake/all/patches/0004-introduce-automake_perllibdir-0.16.1.patch
conan-center-index/recipes/automake/all/patches/0003-remove-embedded-datadirs-introduce-automake-conan-includes-0.16.3.patch
conan-center-index/recipes/automake/all/patches/0001-help2man-no-discard-stderr-0.16.2.patch
conan-center-index/recipes/recastnavigation/all/patches/001_fix_shared_option.patch
conan-center-index/recipes/abseil/all/patches/cmake-install.patch
conan-center-index/recipes/icu/all/patches/0001-67.1-fix-mingw.patch
conan-center-index/recipes/icu/all/patches/6aba9344a18f4f32e8070ee53b79495630901c26.patch
conan-center-index/recipes/libffi/all/patches/0002-3.3-fix-libtool-path.patch
conan-center-index/recipes/libffi/all/patches/0006-3.2.1-library-no-version-suffix.patch
conan-center-index/recipes/libffi/all/patches/0006-3.3-library-no-version-suffix.patch
conan-center-index/recipes/libffi/all/patches/0004-3.3-fix-complex-type-msvc.patch
conan-center-index/recipes/libffi/all/patches/0002-3.2.1-fix-libtool-path.patch
conan-center-index/recipes/libffi/all/patches/0004-3.2.1-fix-complex-type-msvc.patch
conan-center-index/recipes/libffi/all/patches/0005-3.3-do-not-install-libraries-to-arch-dependent-directories.patch
conan-center-index/recipes/libffi/all/patches/0003-3.2.1-fix-win64-assembly.patch
conan-center-index/recipes/libffi/all/patches/0001-3.2.1-add-support-windows-dll.patch
conan-center-index/recipes/libffi/all/patches/0005-3.2.1-do-not-install-libraries-to-arch-dependent-directories.patch
conan-center-index/recipes/poco/all/patches/1.9.2.patch
conan-center-index/recipes/poco/all/patches/1.8.1.patch
conan-center-index/recipes/poco/all/patches/1.10.0-set-missing-cmake-variable.patch
conan-center-index/recipes/poco/all/patches/1.10.1.patch
conan-center-index/recipes/poco/all/patches/1.9.2-2.patch
conan-center-index/recipes/poco/all/patches/1.10.0.patch
conan-center-index/recipes/usockets/all/patches/0002-vcxproj.patch
conan-center-index/recipes/usockets/all/patches/0001-makefile_0.6.0.patch
conan-center-index/recipes/usockets/all/patches/0001-makefile.patch
conan-center-index/recipes/coin-cbc/all/patches/0001-no-pkg-config-check.patch
conan-center-index/recipes/libgettext/all/patches/0003-Reported-by-Gabor-Z.-Papp-gzp-papp.hu.patch
conan-center-index/recipes/libgettext/all/patches/0001-build-Fix-build-errors-with-MSVC.patch
conan-center-index/recipes/libgettext/all/patches/0002-memmove-is-intrinsic-function-on-MSVC.patch
conan-center-index/recipes/cppzmq/all/patches/0002-cmakelists-alias-libzmq-no-export.patch
conan-center-index/recipes/cppzmq/all/patches/0001-cmakelists-alias-libzmq-no-export.patch
conan-center-index/recipes/libest/all/patches/0001-examples-are-broken-don-t-build-them.patch
conan-center-index/recipes/qhull/all/patches/no-cpp11.patch
conan-center-index/recipes/qhull/all/patches/fix-cmake-7.3.2.patch
conan-center-index/recipes/qhull/all/patches/fix-cmake-8.0.x.patch
jgsogo commented 3 years ago

Of course, @a4z , if we agree on a policy and it doesn't match existing recipes we will work on them and fix them. It is exactly what we are already doing when we introduce a new hook or any other policy. This is a collaborative effort, no one of us can take it alone.

I think there are very good reasons and opinions here and in Slack, we try to gather all the feedback and propose something coherent and useful for all, now and in the future.

a4z commented 3 years ago

Hi @jgsogo ,

grep -r tools.replace_in_file recipes | wc -l
     433

don't forget to review all 433 where people use tools.replace, and remove those that modify sources, because people do that since they need working software

it turns more and more out how in what a ridiculous corner you put yourself by letting you confusing of a total incompetent person just because that person is maintainer of a project nobody else wants to maintain, who is total incompetent when it comes to the topic of software delivery , and who had not maged to update and release a new version of his known to be buggy software for very long time now, more time than industry can accept. And also if you would have software that uses auth with mqtt for some of the big cloud providers, you would think different than yo do now, but that's maybe part of the problem, you are too far away of industry use of software and conan, because if you would be responsible for production grade software it would be impossible to behave like you do in this respect. see Javier, it is nothing bad to become confused, follow bad advice, but insist on this direction is a problem, to bad you are on the way to destroy the good opinion I had from you

jgsogo commented 3 years ago

@a4z I'm not going to go personal on this. If you want to, you know you can find me on Slack and sometimes we've been live in the same conference and/or space. Feel free to approach me and we can talk. Same about everyone else, all people here are quite approachable and willing to help. After this COVID-19 that is taking its toll on all of us, I am confident that we will celebrate a ConanDays together, toast and congratulate ourselves for an effort that is bearing fruit.

Please, do not label someone as incompetent, there are many personal circumstances and I'm sure everyone is doing their best when working on OSS, especially if they are working for free on it and/or in their free time. This is also what I think about you and what you do, you are doing your best and you try to help other people here, and I'm really grateful for your comments, your contributions and your help to many users here.

I'm being paid, Conan is my job and ConanCenter is something I do because I love it, but also because I'm paid for it. But I know that this repository wouldn't be possible without all the help of so many people who are working here for free (you included) and I smile and get excited each time I think we are changing the C++ ecosystem, I really think we are changing the future for C++ developers. I would love to write more C++ and I'm sure I will come back to it sooner or later... but at this moment I'm living a dream trying to build the tool I needed two years ago and the one I will use in the future together with an amazing set of libraries available and ready to use.

We need a policy about patching, it can be more or less aligned with your thoughts or mine, with what you need today or tomorrow, with my needs or yours... but I'm sure it needs to be aligned with what ALL OF US (maintainers, reviewers, contributors, authors and consumers) need and what we can afford maintaining in the long term. Tomorrow you and I will be at the other side, only consuming the recipes other people are submitting to conan-center-index, you and I won't be reviewing PRs here anymore. This is what I have in mind when I talk about this topic. This is what we must keep in mind when we propose https://github.com/conan-io/conan-center-index/pull/3951.

SpaceIm commented 3 years ago

I think it is time you ack my PR. Or, remove all recipes with patches that modify code. I found some where the changes are more massive and complex than the very clear and simple patch I added #3834 .

Which ones?

a4z commented 3 years ago

take a look yourself SpaceLm, I posted the list of current patches. I give you just one who does a very similar thing as I did https://github.com/conan-io/conan-center-index/blob/master/recipes/ftjam/all/patches/0001-jam-2.5-overflow.patch this is way more massive the the simple and clear change I posted in the PR, with explaination and link to documentation. where Ian freaked out confused people like Javier.

There are so many patches with no explanation at all, but by my one people freaked out because they listened to a hostile and confused library author.

and sorry Javier, I just wanted to be helpful and point out that you have not thought on all the side effects you cause, and how discriminating you behaviour is (not to mentions Ians behaviour) against those users are who are effected for the bug in paho-mqtt-c , since there is currently no version available on the cci that is usable if you have certain workflows. And this now for long enough, because the persons who train you jumped on does not care about his users, he says wait weeks until the next version, which is insane. That should not be too hard to understand. And this is why your behaviour is making the cci unusable for serious and production use.

prince-chrismc commented 3 years ago

That example is a build tool. The explanation is in the patch...

https://github.com/conan-io/conan-center-index/blob/6490c8cc3d75eff23cd771dc84c561d26051fc87/recipes/ftjam/all/patches/0001-jam-2.5-overflow.patch#L4-L7

And it was specifically added to enable it to work with conan's plentiful compiler options and default paths. Which makes perfect sense.

There's a 2.6.1 that was released last year 🤔 but the downloads are no longer available on sourceforge! Where did they go?!


There has been several issues unaddressed or PRs close/altered simply because they were trying to apply patches that seemed unorthodox. Recent example #3918. There's too many closed issues for me to find them now but feel free to some research.

You are not the first to have a PR stalled due to a patch.

Please have some patients we are trying to resolve the issue. Congratulations for raising this issue and bringing lots of attention t o it, we now have quorum to form a consensus.

a4z commented 3 years ago

there is always some explanation behind double standards, so lets do not go into this,

it is also too boring to go through all existing code patches, do this on your own. And focus on some facts.

Call me crazy, but if you seriously dam me because I am passionate that cci stays to be, and becomes even more, a place where high quality libraries are released, I do not care. That there is a fix since 27 November, but still not a working version nearly a month later. This makes this lib somehow unmaintained, even if there is development going on. We have a first class example for something that gets backported, no big deal, but now it is. Thank you. If it would be about something that is really controversial, but this .... The whole issue is such a no brainer, I find it sad to see what people here do with it, namely saying cci does not care about functional libs. IMHO, this action has damaged the cci to be a trustful place where I can be sure to get the best packages available, and this hurts me somehow because I expected more.

anyhow, I have repeated my self now often enough, I try to get this other eclipse mqtt library to work , and will not invest any more time on this 'issue' or the paho-mqtt-c pull request.

dmn-star commented 3 years ago

Quick points on theory:

  • The policy of "Only official sources ever" has a nice ring to it. It seems like how enterprises think. There's a case to be made.

Why do you think things like BoringSSL exist?