Closed szigetics closed 3 years ago
utf8_string.h starts with
#ifndef LH_UTF8_STRINGS_H
#define LH_UTF8_STRINGS_H
namespace litehtml
{
class utf8_to_wchar
{
const byte* m_utf8;
so it looks like it misses a #include
EDIT: this file comes from https://github.com/litehtml/litehtml/blob/master/include/litehtml/utf8_strings.h#L8 via several git submodules
I reproduced this error both on my computer, and on github actions:
I reported the problem on https://bugreports.qt.io/browse/QTBUG-97765
It looks looks like a conflict between brotli and litehtml both having a file named types.h
. The current workaround is -o qt:with_brotli=False -o freetype:with_brotli=False
could you please report this on https://bugreports.qt.io/ ? utf8_string.h starts with
#ifndef LH_UTF8_STRINGS_H #define LH_UTF8_STRINGS_H namespace litehtml { class utf8_to_wchar { const byte* m_utf8;
so it looks like it misses a
#include
EDIT: this file comes from https://github.com/litehtml/litehtml/blob/master/include/litehtml/utf8_strings.h#L8 via several git submodulesI reproduced this error both on my computer, and on github actions:
It looks looks like a conflict between brotli and litehtml both having a file named
types.h
. The current workaround is-o qt:with_brotli=False -o freetype:with_brotli=False
I didn't report it to Qt (yet) because first I wanted to try to build locally. I followed the build steps as described here : https://doc.qt.io/qt-6/macos-building.html , and the build passed successfully.
I will try to build the recipe with the workaround that you suggested : -o qt:with_brotli=False -o freetype:with_brotli=False
. Thank you!
@ericLemanissier couldn't we also fix this by adding a litehtml conan package and consuming that one in qt. I notice qt also looks for litehtml using find_package first (https://code.qt.io/cgit/playground/qlitehtml.git/tree/src/CMakeLists.txt)
consuming litehtml from conan is better from a packaging standpoint, because then you can choose if it's static or shared, override the version etc. That said, I'm not sure it'l fix the root problem. And I currently don't have time to make such package. Another solution could actually be to include types.h directly in utf8_strings.h, and I think the compiler should prefer to include types.h which is the same folder as utf8_strings.h, instead of another folder in the include path
thanks. I added the patch in https://github.com/conan-io/conan-center-index/pull/7849
Package and Environment Details (include every applicable attribute)
Conan profile (output of
conan profile show default
)Steps to reproduce (Include if Applicable)
Start building of qt/6.2.0 using
conan create . "qt/6.2.0@_/_" -o qt:qttools=True
The build will fail with :C:\.conan\997f5c\1\qt6\qttools\src\assistant\qlitehtml\src\3rdparty\litehtml\include\litehtml\utf8_strings.h(8): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
and other errors in the same file.Logs (Include/Attach if Applicable)
Click to expand log
``` >conan create . "qt/6.2.0@_/_" -o qt:qttools=True Exporting package recipe qt/6.2.0 exports: File 'conandata.yml' found. Exporting it... qt/6.2.0 exports: Copied 1 '.yml' file: conandata.yml qt/6.2.0 exports: Copied 4 '.diff' files: 138a720.diff, 32451d5.diff, c72097e.diff, qt6-pri-helpers-fix.diff qt/6.2.0: Calling export() qt/6.2.0 export() method: Copied 1 '.conf' file: qtmodules6.2.0.conf qt/6.2.0: The stored package has not changed qt/6.2.0: Using the exported files summary hash as the recipe revision: e363cc843891a6451153b94986ec84c7 qt/6.2.0: Exported revision: e363cc843891a6451153b94986ec84c7 Configuration: [settings] arch=x86_64 arch_build=x86_64 build_type=Release compiler=Visual Studio compiler.runtime=MD compiler.version=16 os=Windows os_build=Windows [options] qt:qttools=True [build_requires] [env] WARN: harfbuzz/2.8.0: requirement freetype/2.11.0 overridden by qt/6.2.0 to freetype/2.10.4 libgettext/0.20.1: WARN: Recipe 'libgettext/0.20.1' is deprecated in favor of 'gettext'. Please, consider changing your requirements. pcre/8.45: WARN: Package binary is corrupted, removing: e87a8a0d1a34c63e57cfcfa8aa6088b17582df41 qt/6.2.0: Forced build from source qt/6.2.0 (test package): Installing package Requirements brotli/1.0.9 from 'conancenter' - Cache bzip2/1.0.8 from local cache - Cache double-conversion/3.1.5 from 'conancenter' - Cache freetype/2.10.4 from 'conancenter' - Cache glib/2.70.0 from 'conancenter' - Cache harfbuzz/2.8.0 from 'conancenter' - Cache libelf/0.8.13 from 'conancenter' - Cache libffi/3.4.2 from 'conancenter' - Cache libgettext/0.20.1 from 'conancenter' - Cache libiconv/1.16 from 'conancenter' - Cache libpng/1.6.37 from local cache - Cache libpq/13.2 from 'conancenter' - Cache openssl/1.1.1l from 'conancenter' - Cache pcre/8.45 from 'conancenter' - Cache pcre2/10.37 from local cache - Cache qt/6.2.0 from local cache - Cache sqlite3/3.36.0 from 'conancenter' - Cache zlib/1.2.11 from local cache - Cache Packages brotli/1.0.9:3fb49604f9c2f729b85ba3115852006824e72cab - Cache bzip2/1.0.8:d16a91eadaaf5829b928b12d2f836ff7680d3df5 - Cache double-conversion/3.1.5:3fb49604f9c2f729b85ba3115852006824e72cab - Cache freetype/2.10.4:27b2733304cef577b19f699fec3a5bdbefb36d16 - Download glib/2.70.0:39022ddb4abc5a55ae186ee8c99842984908fec8 - Download harfbuzz/2.8.0:1f8752c5b0764c0d6010d417fc2e020549726cc2 - Download libelf/0.8.13:3fb49604f9c2f729b85ba3115852006824e72cab - Cache libffi/3.4.2:3fb49604f9c2f729b85ba3115852006824e72cab - Cache libgettext/0.20.1:b3e4dccd9a7572a5a29c77cc68475a955d494ef7 - Cache libiconv/1.16:3fb49604f9c2f729b85ba3115852006824e72cab - Cache libpng/1.6.37:d140711d95cc16a85766a8fc3a551dfafe84cf63 - Cache libpq/13.2:3fb49604f9c2f729b85ba3115852006824e72cab - Cache openssl/1.1.1l:3fb49604f9c2f729b85ba3115852006824e72cab - Cache pcre/8.45:e87a8a0d1a34c63e57cfcfa8aa6088b17582df41 - Download pcre2/10.37:c3909bc59b2700f5c593b64eb3cdec0e85b05bc5 - Download qt/6.2.0:3781a22824f886e20502843c22cb538028a5e0ce - Build sqlite3/3.36.0:050fb3a4d3559ab088bce91739e61889c28839d1 - Cache zlib/1.2.11:3fb49604f9c2f729b85ba3115852006824e72cab - Cache Build requirements cmake/3.21.3 from 'conancenter' - Cache ninja/1.10.2 from 'conancenter' - Cache pkgconf/1.7.4 from 'conancenter' - Cache strawberryperl/5.30.0.1 from local cache - Cache Build requirements packages cmake/3.21.3:0a420ff5c47119e668867cdb51baff0eca1fdb68 - Cache ninja/1.10.2:0a420ff5c47119e668867cdb51baff0eca1fdb68 - Cache pkgconf/1.7.4:3fb49604f9c2f729b85ba3115852006824e72cab - Cache strawberryperl/5.30.0.1:ca33edce272a279b24f87dc0d4cf5bbdcffbc187 - Cache Installing (downloading, building) binaries... pcre/8.45: Retrieving package e87a8a0d1a34c63e57cfcfa8aa6088b17582df41 from remote 'conancenter' Downloading conanmanifest.txt completed [0.50k] Downloading conaninfo.txt completed [1.18k] Downloading conan_package.tgz completed [469.51k] Decompressing conan_package.tgz completed [0.00k] pcre/8.45: Package installed e87a8a0d1a34c63e57cfcfa8aa6088b17582df41 pcre/8.45: Downloaded package revision b7ee7541145fa04fb8f19024f194ddd4 pcre2/10.37: Retrieving package c3909bc59b2700f5c593b64eb3cdec0e85b05bc5 from remote 'conancenter' Downloading conanmanifest.txt completed [0.51k] Downloading conaninfo.txt completed [0.98k] Downloading conan_package.tgz completed [601.57k] Decompressing conan_package.tgz completed [0.00k] pcre2/10.37: Package installed c3909bc59b2700f5c593b64eb3cdec0e85b05bc5 pcre2/10.37: Downloaded package revision 66be5b234a4287c8237ee3f7bd6511f5 freetype/2.10.4: Retrieving package 27b2733304cef577b19f699fec3a5bdbefb36d16 from remote 'conancenter' Downloading conanmanifest.txt completed [4.29k] Downloading conaninfo.txt completed [1.06k] Downloading conan_package.tgz completed [822.67k] Decompressing conan_package.tgz completed [0.00k] freetype/2.10.4: Package installed 27b2733304cef577b19f699fec3a5bdbefb36d16 freetype/2.10.4: Downloaded package revision 9e7262b7d777fb799ba567531fd25261 glib/2.70.0: Retrieving package 39022ddb4abc5a55ae186ee8c99842984908fec8 from remote 'conancenter' Downloading conanmanifest.txt completed [20.66k] Downloading conaninfo.txt completed [1.54k] Downloading conan_package.tgz completed [2757.39k] Decompressing conan_package.tgz completed [0.00k] glib/2.70.0: Package installed 39022ddb4abc5a55ae186ee8c99842984908fec8 glib/2.70.0: Downloaded package revision 04474aed90304385d18a2748bafa7ede harfbuzz/2.8.0: Retrieving package 1f8752c5b0764c0d6010d417fc2e020549726cc2 from remote 'conancenter' Downloading conanmanifest.txt completed [2.13k] Downloading conaninfo.txt completed [2.19k] Downloading conan_package.tgz completed [717.03k] Decompressing conan_package.tgz completed [0.00k] harfbuzz/2.8.0: Package installed 1f8752c5b0764c0d6010d417fc2e020549726cc2 harfbuzz/2.8.0: Downloaded package revision 038bbcd10dbfc12d5da1133192c00e5a brotli/1.0.9: Already installed! bzip2/1.0.8: Already installed! bzip2/1.0.8: Appending PATH environment variable: C:\Users\CsabaSzigeti\.conan\data\bzip2\1.0.8\_\_\package\d16a91eadaaf5829b928b12d2f836ff7680d3df5\bin cmake/3.21.3: Already installed! cmake/3.21.3: Appending PATH environment variable: C:\Users\CsabaSzigeti\.conan\data\cmake\3.21.3\_\_\package\0a420ff5c47119e668867cdb51baff0eca1fdb68\bin cmake/3.21.3: Appending PATH environment variable: C:\Users\CsabaSzigeti\.conan\data\cmake\3.21.3\_\_\package\0a420ff5c47119e668867cdb51baff0eca1fdb68\bin double-conversion/3.1.5: Already installed! libelf/0.8.13: Already installed! libffi/3.4.2: Already installed! libiconv/1.16: Already installed! libiconv/1.16: Appending PATH environment var: C:\Users\CsabaSzigeti\.conan\data\libiconv\1.16\_\_\package\3fb49604f9c2f729b85ba3115852006824e72cab\bin libpq/13.2: Already installed! ninja/1.10.2: Already installed! openssl/1.1.1l: Already installed! pkgconf/1.7.4: Already installed! pkgconf/1.7.4: Appending PATH env var: C:\Users\CsabaSzigeti\.conan\data\pkgconf\1.7.4\_\_\package\3fb49604f9c2f729b85ba3115852006824e72cab\bin pkgconf/1.7.4: Setting PKG_CONFIG env var: C:/Users/CsabaSzigeti/.conan/data/pkgconf/1.7.4/_/_/package/3fb49604f9c2f729b85ba3115852006824e72cab/bin/pkgconf.exe pkgconf/1.7.4: Appending AUTOMAKE_CONAN_INCLUDES env var: /c/users/csabaszigeti/.conan/data/pkgconf/1.7.4/_/_/package/3fb49604f9c2f729b85ba3115852006824e72cab/bin/aclocal sqlite3/3.36.0: Already installed! sqlite3/3.36.0: Appending PATH env var with : C:\Users\CsabaSzigeti\.conan\data\sqlite3\3.36.0\_\_\package\050fb3a4d3559ab088bce91739e61889c28839d1\bin strawberryperl/5.30.0.1: Already installed! strawberryperl/5.30.0.1: Appending PATH environment variable: C:\.conan\3be6c8\1\bin zlib/1.2.11: Already installed! libgettext/0.20.1: Already installed! libpng/1.6.37: Already installed! pcre/8.45: Appending PATH environment variable: C:\Users\CsabaSzigeti\.conan\data\pcre\8.45\_\_\package\e87a8a0d1a34c63e57cfcfa8aa6088b17582df41\bin pcre2/10.37: Appending PATH environment variable: C:\Users\CsabaSzigeti\.conan\data\pcre2\10.37\_\_\package\c3909bc59b2700f5c593b64eb3cdec0e85b05bc5\bin glib/2.70.0: Appending PATH env var with: C:\.conan\9cc518\1\bin qt/6.2.0: Applying build-requirement: cmake/3.21.3 qt/6.2.0: Applying build-requirement: ninja/1.10.2 qt/6.2.0: Applying build-requirement: pkgconf/1.7.4 qt/6.2.0: Applying build-requirement: strawberryperl/5.30.0.1 qt/6.2.0: Configuring sources in C:\.conan\997f5c\1 Downloading qt-everywhere-src-6.2.0.tar.xz completed [651312.18k] qt/6.2.0: Building your package in C:\.conan\518327\1 qt/6.2.0: Generator pkg_config created cmake.pc qt/6.2.0: Generator pkg_config created ninja.pc qt/6.2.0: Generator pkg_config created libpkgconf.pc qt/6.2.0: Generator pkg_config created strawberryperl.pc qt/6.2.0: Generator pkg_config created libcrypto.pc qt/6.2.0: Generator pkg_config created libssl.pc qt/6.2.0: Generator pkg_config created openssl.pc qt/6.2.0: Generator pkg_config created libpcre2-32.pc qt/6.2.0: Generator pkg_config created libpcre2-16.pc qt/6.2.0: Generator pkg_config created libpcre2-8.pc qt/6.2.0: Generator pkg_config created libpcre2-posix.pc qt/6.2.0: Generator pkg_config created libpcre2.pc qt/6.2.0: Generator pkg_config created double-conversion.pc qt/6.2.0: Generator pkg_config created harfbuzz.pc qt/6.2.0: Generator pkg_config created sqlite.pc qt/6.2.0: Generator pkg_config created sqlite3.pc qt/6.2.0: Generator pkg_config created pgport.pc qt/6.2.0: Generator pkg_config created pgcommon.pc qt/6.2.0: Generator pkg_config created pq.pc qt/6.2.0: Generator pkg_config created libpq.pc qt/6.2.0: Generator pkg_config created freetype2.pc qt/6.2.0: Generator pkg_config created gresource.pc qt/6.2.0: Generator pkg_config created glib-2.0.pc qt/6.2.0: Generator pkg_config created gobject-2.0.pc qt/6.2.0: Generator pkg_config created gmodule-no-export-2.0.pc qt/6.2.0: Generator pkg_config created gmodule-2.0.pc qt/6.2.0: Generator pkg_config created gio-2.0.pc qt/6.2.0: Generator pkg_config created gio-windows-2.0.pc qt/6.2.0: Generator pkg_config created gthread-2.0.pc qt/6.2.0: Generator pkg_config created gmodule-export-2.0.pc qt/6.2.0: Generator pkg_config created glib.pc qt/6.2.0: Generator pkg_config created libpng.pc qt/6.2.0: Generator pkg_config created libbrotlicommon.pc qt/6.2.0: Generator pkg_config created libbrotlienc.pc qt/6.2.0: Generator pkg_config created libbrotlidec.pc qt/6.2.0: Generator pkg_config created brotli.pc qt/6.2.0: Generator pkg_config created libffi.pc qt/6.2.0: Generator pkg_config created libpcre32.pc qt/6.2.0: Generator pkg_config created libpcre16.pc qt/6.2.0: Generator pkg_config created libpcre.pc qt/6.2.0: Generator pkg_config created libpcreposix.pc qt/6.2.0: Generator pkg_config created pcre.pc qt/6.2.0: Generator pkg_config created libelf.pc qt/6.2.0: Generator pkg_config created libgettext.pc qt/6.2.0: Generator pkg_config created zlib.pc qt/6.2.0: Generator pkg_config created bzip2.pc qt/6.2.0: Generator pkg_config created libiconv.pc qt/6.2.0: Generator cmake_find_package created Findcmake.cmake qt/6.2.0: Generator cmake_find_package created Findninja.cmake qt/6.2.0: Generator cmake_find_package created Findpkgconf.cmake qt/6.2.0: Generator cmake_find_package created Findstrawberryperl.cmake qt/6.2.0: Generator cmake_find_package created FindOpenSSL.cmake qt/6.2.0: Generator cmake_find_package created Findpcre2.cmake qt/6.2.0: Generator cmake_find_package created Finddouble-conversion.cmake qt/6.2.0: Generator cmake_find_package created Findharfbuzz.cmake qt/6.2.0: Generator cmake_find_package created FindSQLite3.cmake qt/6.2.0: Generator cmake_find_package created FindPostgreSQL.cmake qt/6.2.0: Generator cmake_find_package created FindFreetype.cmake qt/6.2.0: Generator cmake_find_package created Findglib.cmake qt/6.2.0: Generator cmake_find_package created FindPNG.cmake qt/6.2.0: Generator cmake_find_package created FindBrotli.cmake qt/6.2.0: Generator cmake_find_package created Findlibffi.cmake qt/6.2.0: Generator cmake_find_package created FindPCRE.cmake qt/6.2.0: Generator cmake_find_package created Findlibelf.cmake qt/6.2.0: Generator cmake_find_package created Findlibgettext.cmake qt/6.2.0: Generator cmake_find_package created FindZLIB.cmake qt/6.2.0: Generator cmake_find_package created FindBZip2.cmake qt/6.2.0: Generator cmake_find_package created FindIconv.cmake qt/6.2.0: Generator cmake created conanbuildinfo.cmake qt/6.2.0: Aggregating env generators qt/6.2.0: Calling build() WARN: replace_in_file didn't find pattern '$<$