search

conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)
MIT License
166 stars 71 forks source link

The latest CPT is broken? #499

Closed mpusz closed 4 years ago

mpusz commented 4 years ago

In the latest Travis CI run I got the following errors:

Traceback (most recent call last):
  File "build.py", line 26, in <module>
    builder.run()
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/cpt/packager.py", line 599, in run
    self.run_builds(base_profile_name=base_profile_name)
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/cpt/packager.py", line 728, in run_builds
    r.run(pull_image=not pulled_docker_images[docker_image],
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/cpt/runner.py", line 251, in run
    envs = self.get_env_vars()
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/cpt/runner.py", line 338, in get_env_vars
    ret["CPT_BUILD_POLICY"] = escape_env(self._build_policy.join(",")) if self._build_policy else escape_env(self._build_policy)
AttributeError: 'list' object has no attribute 'join'
The command "./.travis/run.sh" exited with 1.

See more here: https://travis-ci.com/github/mpusz/units/jobs/349892743#L352-L364.

ericLemanissier commented 4 years ago

it looks like https://github.com/conan-io/conan-package-tools/pull/497#issuecomment-642828179

uilianries commented 4 years ago

@mpusz please update your script to use list, because we can have multiple build policies listed.

mpusz commented 4 years ago

I did (https://github.com/mpusz/units/blob/master/build.py#L12) but it didn't help (https://travis-ci.com/github/mpusz/units/jobs/349975659) 😢

uilianries commented 4 years ago

@mpusz Thanks for your feedback! I'll check it further.

ericLemanissier commented 4 years ago

the same issue is happening here https://github.com/bincrafters/conan-qt/runs/779773713#step:5:85

uilianries commented 4 years ago

Hi everyone! We should release a new version today (0.33.1) which contains a fix.

ericLemanissier commented 4 years ago

And we're back on track, thanks !

uilianries commented 4 years ago

back on the rails

mpusz commented 4 years ago

Thank you!

ericLemanissier commented 4 years ago

@uilianries I'm wondering if by re-railing the case where build_policy is explictely defined, we did not de-railed the case where build_policy is not explictely defined: https://ci.appveyor.com/project/bincrafters/conan-qt/build/job/lgfr57i3el6aqxw4#L354 All the requirements now have Forced build from source

uilianries commented 4 years ago

@ericLemanissier that's weird, because Bincrafters package tools don't change the build policy, it's None by default, which is the same value for Conan package tools. I need to investigate further

uilianries commented 4 years ago

@ericLemanissier The PR #507 contains a fix for that problem. Thanks for reporting. We should release a new version today or monday (depending of CI time).

ericLemanissier commented 4 years ago

once again, thanks! I'm crossing fingers for CI to finish early

uilianries commented 4 years ago

Hello again! New release available for download (no more bug I hope)!

https://pypi.org/project/conan-package-tools/0.33.2/