Pass cwd to DockerCreateRunner, #447

conan-io / conan-package-tools

Conan Package Tools. Helps with massive package creation and CI integration (Travis CI, Appveyor...)

MIT License

166 stars 71 forks source link

Pass cwd to DockerCreateRunner, #447 #528

Closed theirix closed 3 years ago

theirix commented 4 years ago

Fixes PR #447

The patch allows building packages using Docker in non-flat repositories with specifying cwd.

Example:

builder = ConanMultiPackager(cwd=os.path.join(os.getcwd(), 'recipes', 'foobar'))

Changelog: Feature: Pass cwd to DockerCreateRunner

[ ] Refer to the issue that supports this Pull Request.
[ ] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x] I've read the Contributing guide.
[x] I've followed the PEP8 style guides for Python code.

theirix commented 4 years ago

Seems like master should be merged to develop with 1.30 upgrade

Croydon commented 4 years ago

I hit this issue too and fixed it in the same way https://github.com/Croydon/conan-package-tools/commit/7c0a4552e81aac49159b8a6030209385dcbc5cfa

I definitely should have searched here before 😄

@uilianries could you please have a look?

theirix commented 4 years ago

Unfortunately, the same:

Exception: Conan/CPT version mismatch. Conan version installed: 1.31.0 . 
This version of CPT supports only Conan < 1.30

Croydon commented 4 years ago

I think you have to do a git fetch upstream && git rebase upstream/develop

theirix commented 4 years ago

I think you have to do a git fetch upstream && git rebase upstream/develop

Rebased but support for 1.31.0 (#530) is not merged yet.

Croydon commented 4 years ago

Somewhat weird that CPT is using a testing suite for versions it doesn't yet support

Anyhow, I guess now you can re-base and it should work?

theirix commented 4 years ago

Somewhat weird that CPT is using a testing suite for versions it doesn't yet support

Anyhow, I guess now you can re-base and it should work?

Almost! Now one of builds complaints with "Exception: Conan/CPT version mismatch. Conan version installed: 1.32.0 . This version of CPT supports only Conan < 1.31" :(

Croydon commented 4 years ago

I don't understand the CI setup and the error has clearly nothing to do with this pull request

@uilianries How do we move this forward?

Croydon commented 4 years ago

@theirix Could you update the value of NEWEST_CONAN_SUPPORTED and the version in requirements.txt for Conan 1.32.0?

The current develop branch fails too because of this

https://github.com/conan-io/conan-package-tools/commit/245b72193b95a8d3d2fb8e70b53fbb37d11cd2aa

theirix commented 4 years ago

@Croydon tried but the build fails again. Probably it is conan==1.32.0.dev0 vs 1.32.0

Croydon commented 3 years ago

Requires https://github.com/conan-io/conan-package-tools/pull/531

uilianries commented 3 years ago

PR #531 has been merged. Let's see the next result for this PR.

Croydon commented 3 years ago

Success! 🎉

uilianries commented 3 years ago

Thank you all!