kasunch commented 3 years ago

Changelog: Fix: Fixes the issue with sensitive details are exposed in build log files

fixes #535

[x] Refer to the issue that supports this Pull Request.
[x] If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
[x] I've read the Contributing guide.
[x] I've followed the PEP8 style guides for Python code.

CLAassistant commented 3 years ago

All committers have signed the CLA.

uilianries commented 3 years ago

It looks great. Is it possible add a test to check this new output?

uilianries commented 3 years ago

Depends on https://github.com/conan-io/conan/pull/8132

uilianries commented 3 years ago

Depends on https://github.com/conan-io/conan-package-tools/pull/538

codecov-io commented 3 years ago

Codecov Report

Merging #536 (3110972) into develop (b6d6816) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
+ Coverage    79.13%   79.21%   +0.08%     
===========================================
  Files           41       41              
  Lines         4917     4932      +15     
===========================================
+ Hits          3891     3907      +16     
+ Misses        1026     1025       -1

Impacted Files	Coverage Δ
cpt/runner.py	`91.52% <100.00%> (+0.18%)`	:arrow_up:
cpt/test/integration/docker_test.py	`88.88% <100.00%> (+1.13%)`	:arrow_up:
cpt/test/integration/base.py	`97.56% <0.00%> (+2.43%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6d6816...3110972. Read the comment docs.

conan-io / conan-package-tools

Hide sensitive information from getting displayed/logged. #536

Codecov Report